web icon indicating copy to clipboard operation
web copied to clipboard

[a11y] 9.4.1.2 - Name, role, value available

Open tbsbdr opened this issue 3 years ago • 7 comments

  • Context: The Web UI should be accessible according to the WCAG2.1 /BITV 2.0 guidelines. The number in the title relates to the test-steps: https://www.bitvtest.de/bitv_test/das_testverfahren_im_detail/pruefschritte.html
  • "Status" relates to the evaluation scheme https://www.bitvtest.de/bitv_test/das_testverfahren_im_detail/verfahren.html#c1262
  • "a11y" is short for accessibility

General notes

  • All pages: for the elements of the user menue (Liste mit "Profil", "Einstellungen", etc.) ARIA role="tooltip" was used. In this case this is not correct as it has an other purpose - "A contextual popup that displays a description for an element.". The roles should be removed. Also using the aria-describedby attribute on the button "Benutzermenü" in the expanded sub menue is not necessary.
  • Pages 1 to 3 / modal dialogues: using aria-labelledby ( aria-labelledby="ocmodal-title" ) is not allowed on div und span elements as screenreader won’t handle the attribute reliable. An accessible sample can be found here: https://www.w3.org/TR/wai-aria-practices-1.1/examples/dialog-modal/dialog.html.
  • Note: the anchor links (in this case "Zum Hauptinhalt springen") should be implemented as links and not as buttons.

Status: rather fulfilled

  • Page 4 (Konto) See general notes

Status: partly fulfilled

  • Page 1 (Alle Dateien) When copying or moving an element (Folder or file) a new page is opened. On opening (because of using aria-live="polite“) the text "Zur Seite files- location-picker navigiert" is read by screenreaders. This text contains an English variable and is not informative. A better solution would be to remove aria-live="polite" and move the keyboard focus with tabindex="-1" on the h1-heading on page load. See general notes

  • Page 2 (Mit anderen geteilten Dateien) See general notes

  • Page 3 (Gelöschte Dateien) See general notes

tbsbdr avatar Jun 25 '21 20:06 tbsbdr

I think we will run into a problem with the role="tooltip", as of my knowledge and what I found on google role="tooltip" is set by tippy itself and I don't find a way to turn it off.

lookacat avatar Jul 26 '21 14:07 lookacat

I think we will run into a problem with the role="tooltip", as of my knowledge and what I found on google role="tooltip" is set by tippy itself and I don't find a way to turn it off.

Should be possible (according to https://kabbouchi.github.io/tippyjs-v4-docs/all-options/, search for "role" on this page) in OcTooltip.js in the design system, yet haven't tried it myself

pascalwengerter avatar Jul 26 '21 14:07 pascalwengerter

@pascalwengerter oh thx didnt see that

lookacat avatar Jul 26 '21 14:07 lookacat

role from tippy removed in https://github.com/owncloud/owncloud-design-system/pull/1530/commits/2ef8eaa69d85f54144e4c2a566b088e8588c7066

kulmann avatar Aug 24 '21 09:08 kulmann

aria-labelledby moved to correct element in modal in ODS commit https://github.com/owncloud/owncloud-design-system/pull/1530/commits/2def9143d1fdeb7a180fb4829ad123ec506c5526

kulmann avatar Aug 24 '21 10:08 kulmann

page title for location picker is fixed in https://github.com/owncloud/web/pull/5512/commits/dac2db7dd0204486a8ff3b84737c0e510b8b7fa7 but needs german translations (will do that in bulk later)

kulmann avatar Aug 24 '21 10:08 kulmann

We won't fix the Note: the anchor links (in this case "Zum Hauptinhalt springen") should be implemented as links and not as buttons. and keep it as a button instead, since it's no violation and would need major refactoring.

kulmann avatar Aug 24 '21 10:08 kulmann