web icon indicating copy to clipboard operation
web copied to clipboard

Decide how to proceed with `manifest.json`

Open pascalwengerter opened this issue 4 years ago • 2 comments

Context

In order to being able to use web as a progressive web app, we deliver a manifest.json file to our users. The content of this file should be information for how the app should be displayed and handled, by referencing images/logos for different clients, text snippets and colors. More details here

Actual behaviour

When running with oCIS and since #4925 when running with OC10, a manifest.json gets delivered to the client but the content of the file is perhaps outdated.

Currently, the file looks like this:

{
	"name": "Web | ownCloud",
	"short_name": "Web",
	"icons": [{
		"src": "/img/app.png",
		"sizes": "512x512",
		"type": "image/png"
	}],

	"start_url": "/",

	"display": "fullscreen",
	"orientation": "portrait",

	"background_color": "#FFFFFF",
	"theme_color": "#375f7E"
}

There's a couple of issues:

  • Wrong icon
  • No differention in icon sizes/formats for different clients
  • No theme-able name (since theming landed in web, admins perhaps want to reflect their changes in the manifest.json, too)
  • No valid start_url

Expected behaviour

We provide the user with a manifest file that includes all the necessary information & references for logos/icons. Also, the information in the manifest file gets updated if a theme with respective values is present.

Questions to answered

  • how do we handle different paths when loading files in OC10/oCIS (e.g. by providing two different manifest files for the two backends)
  • what information do we need to collect in the theming steps and how do we overwrite the values in the manifest file
  • do we want to keep the manifest.json or should we remove the file not to raise false hopes until it's properly supported (including service workers etc)

pascalwengerter avatar Apr 08 '21 11:04 pascalwengerter

@kulmann @LukasHirt @fschade opinions?

pascalwengerter avatar Apr 08 '21 14:04 pascalwengerter

We need to keep manifest.json in order to keep it working with Mac OS web apps. In meantime I adjusted the icon in order to make it look fine for this purpose.

AlexAndBear avatar Feb 07 '24 22:02 AlexAndBear

Closing this due to inactivity / lack of reaction

pascalwengerter avatar Jun 05 '25 15:06 pascalwengerter