web icon indicating copy to clipboard operation
web copied to clipboard

refactor: use ids for copy and move operations

Open JammingBen opened this issue 1 year ago • 3 comments

Description

As per title.

Also fixes as issue where listFiles with only a space provided would fail. The webdav path now falls back to the space webdav path if no path or fileId are being provided.

Related Issue

  • works towards https://github.com/owncloud/web/issues/9786

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [x] Technical debt
  • [ ] Tests
  • [ ] Documentation
  • [ ] Maintenance (e.g. dependency updates or tooling)

JammingBen avatar Jul 16 '24 11:07 JammingBen

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

update-docs[bot] avatar Jul 16 '24 11:07 update-docs[bot]

This solution currently doesn't work on public pages because we still need to work with paths on those. We could introduce checks and keep supporting paths and ids, but I don't really like this.

Maybe https://github.com/owncloud/ocis/issues/9623 gets resolved in the near future, then we can omit paths completely for copy- and move-operations.

JammingBen avatar Jul 16 '24 13:07 JammingBen

Closing because of https://github.com/owncloud/web/pull/11199#issuecomment-2230878625, this doesn't seem to get attention in the backend.

JammingBen avatar Nov 05 '24 08:11 JammingBen