web icon indicating copy to clipboard operation
web copied to clipboard

feat: make unsynced shares accessible

Open JammingBen opened this issue 1 month ago • 4 comments

Description

Makes unsynced shares accessible. The way to make this work is by using the remote item id instead of the share jail id for opening/resolving into incoming shares.

Notable changes in the course of this:

  • Renames shareId to remoteItemId and shareRoot to remoteItemPath on resources to match with the Graph terminology.
  • Removes the remoteItemId on space resources because it only matters for share spaces, in which case this is simply the space id. That means instead of blindly going for space.remoteItemId, it now checks if the space is actually a share space and then uses its id.

Needs https://github.com/owncloud/ocis/pull/9095.

Related Issue

  • Fixes https://github.com/owncloud/web/issues/9784

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Technical debt
  • [ ] Tests
  • [ ] Documentation
  • [ ] Maintenance (e.g. dependency updates or tooling)

JammingBen avatar May 08 '24 06:05 JammingBen

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

update-docs[bot] avatar May 08 '24 06:05 update-docs[bot]

Todo: handle legacy urls

dschmidt avatar May 08 '24 06:05 dschmidt

Todo: handle legacy urls

Discussed with @tbsbdr , it's okay for the URLs to break because of the shareId.

Edit: We decided to built a fallback anyway since it was easy.

JammingBen avatar May 08 '24 07:05 JammingBen

LGTM, we should add E2E tests for this

Agreed, I created https://github.com/owncloud/web/issues/10931 to keep track.

JammingBen avatar May 17 '24 13:05 JammingBen

Congrats to us! 🎉

dschmidt avatar May 21 '24 08:05 dschmidt