feat: make unsynced shares accessible
Description
Makes unsynced shares accessible. The way to make this work is by using the remote item id instead of the share jail id for opening/resolving into incoming shares.
Notable changes in the course of this:
- Renames
shareIdtoremoteItemIdandshareRoottoremoteItemPathon resources to match with the Graph terminology. - Removes the
remoteItemIdon space resources because it only matters for share spaces, in which case this is simply the space id. That means instead of blindly going forspace.remoteItemId, it now checks if the space is actually a share space and then uses its id.
Needs https://github.com/owncloud/ocis/pull/9095.
Related Issue
- Fixes https://github.com/owncloud/web/issues/9784
Types of changes
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] Technical debt
- [ ] Tests
- [ ] Documentation
- [ ] Maintenance (e.g. dependency updates or tooling)
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.
Todo: handle legacy urls
Todo: handle legacy urls
Discussed with @tbsbdr , it's okay for the URLs to break because of the shareId.
Edit: We decided to built a fallback anyway since it was easy.
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
LGTM, we should add E2E tests for this
Agreed, I created https://github.com/owncloud/web/issues/10931 to keep track.
Congrats to us! 🎉