web icon indicating copy to clipboard operation
web copied to clipboard

[a11y] 9.2.4.6 Meaningful headings and labels

Open tschiebel opened this issue 10 months ago • 5 comments

audit: https://infinite.owncloud.com/s/PnaAukHGGsLnrMM

https://bitvtest.de/pruefschritt/bitv-20-web/bitv-20-web-9-2-4-6-aussagekraeftige-ueberschriften-und-beschriftungen

Personal

  • [ ] There are several "h4" headings in the "Approvals" area, all of which have the same title "Link". This can be confusing for users. To create a clear and unambiguous structure, it is recommended that the titles be adapted accordingly, for example "Link 1", "Link 2", etc.

Shares

  • [ ] See commentary on Personal

Spaces

  • [ ] Members" areas - "See commentary on Personal"

tschiebel avatar Apr 05 '24 09:04 tschiebel

Open to suggestions on how to solve this (esp. for existing shares), since we create the link share with the translated but hardcoded name "Link" in https://github.com/owncloud/web/blob/d1154ee6bb6e9d35064db3d39f484e729e60fd5c/packages/web-pkg/src/composables/actions/files/useFileActionsCreateLink.ts#L115

pascalwengerter avatar Apr 11 '24 07:04 pascalwengerter

@tbsbdr assigning you for RE/specification

pascalwengerter avatar Apr 11 '24 08:04 pascalwengerter

@tschiebel FYI "Freigaben" is (I assume) accidentially translated to "Approvals", but should refer to "Shares"

pascalwengerter avatar Apr 11 '24 08:04 pascalwengerter

this is meant (screenshot) thinking aloud how this could be solved: we once thought about enumerating links (link 1, link 2 etc.) but decided against it, because its misleading if links get deleted "it says link 4, but where is link 3?". we could add a date time but then it would get really verbose and the ui would get really cluttered. any other ideas? screenshot_002552

tbsbdr avatar Apr 11 '24 08:04 tbsbdr

Agreed with @tbsbdr that we'll count the existing links and pass it to link creation, so we'll create Link ($number) in the backend (according to the behaviour in the old web UI, see e.g. https://demo.owncloud.com/apps/files/)

pascalwengerter avatar Apr 24 '24 08:04 pascalwengerter

  • SR-only span in h-element with hardcoded creation datetime

tbsbdr avatar Aug 19 '24 09:08 tbsbdr