web
web copied to clipboard
owncloud
[a11y] 9.1.3.1a HTML structural elements for headlines
audit: https://infinite.owncloud.com/s/PnaAukHGGsLnrMM
https://bitvtest.de/pruefschritt/bitv-20-web/bitv-20-web-9-1-3-1a-html-strukturelemente-fuer-ueberschriften
Personal space: Partially fulfilled.
-
[ ] There is an "h1" heading on the page, but it is empty and is not output by not displayed by screen readers. In order to improve accessibility, it is accessibility, it is recommended to use the word "Personal" as the "h1" heading, as this is the is the main heading of the page.
-
[ ] The clearly visually recognizable heading "Share with people" of the user-defined tooltip in the "Shares" area is not marked as such with heading markup.
Approvals: Partially fulfilled.
- [ ] The clearly visually recognizable heading "Share with people" of the user-defined tooltip in the tooltip in the "Shares" section is not marked as such with heading markup. labeled as such. The same problem applies to the heading "Please select how access is granted". access is granted"
Spaces: Partially fulfilled.
- [ ] The clearly visually recognizable heading "Add members to this space" of the custom tooltip in the user-defined tooltip in the "Members" area is not labeled as such with heading markup. The same problem also affects the heading "Please select, how access is granted".
Info: deleted Files and Account: Fulfilled.
- The personal page has a correct
<h1>text content by now - Custom tooltip headings have been fixed via https://github.com/owncloud/web/commit/78cafa8cee31781edb32621d662bf6be4ec0a712
- Can't locate the text "Please select how access is granted"
h-tags are driving me mad... just noticed that inside the Shares panel of the right sidebar, the strings Share with people and Share via link are h3 tags, while they should be h4 tags.
In general I'm afraid that the OcInfoDrop needs to have a dynamic heading level. Maybe we even need to make it a required prop, so that devs really need to think about which heading level to use...