user_ldap icon indicating copy to clipboard operation
user_ldap copied to clipboard

Exception and stacktrace when username not foudn on ldap

Open tomneedham opened this issue 7 years ago • 4 comments

@jvillafanez:

The problem comes from https://github.com/owncloud/user_ldap/blob/master/lib/User_LDAP.php#L101 where we throw a plain exception intended to be used when we don't find the user. We CAN'T distinguish that exception from any other that could happen when we check for the password (https://github.com/owncloud/user_ldap/blob/master/lib/User_LDAP.php#L118)

Changing the log level might not be a good solution because any other exception will also be silenced, specially those that aren't expected. This will make debugging more annoying.

We should add a good exception handling, probably after all the rewrite @butonic is doing.

tomneedham avatar Jan 02 '18 15:01 tomneedham

Now that the rewrite of user_ldap is basically done it would be great if we could move this forward.

pako81 avatar Feb 08 '18 12:02 pako81

@tomneedham @butonic @jvillafanez Any news here?

cdamken avatar Apr 30 '18 14:04 cdamken

Not sure how much this have changed, but it will likely require planning because the error handling was near non-existing back in the days. Proper error handling needs time, so I don't think there will be progress here unless scheduled, other than minor changes from other issues.

jvillafanez avatar May 03 '18 09:05 jvillafanez

Fix here https://github.com/owncloud/user_ldap/pull/269

tomneedham avatar Aug 17 '18 14:08 tomneedham