owncloud-sdk icon indicating copy to clipboard operation
owncloud-sdk copied to clipboard

Bugfix propfind response cut off

Open lookacat opened this issue 2 years ago • 3 comments

We've fixed an issue where _parsePropNode in the dav client cut off subobjects of an object.

lookacat avatar Apr 01 '22 13:04 lookacat

Tried running the failing oCIS Providertests locally

Steps:

  • Start oCIS from around the commitid linked in .drone.env in the web repo (updated docker-compose and run docker compose up ocis)
  • Run PROVIDER_BASE_URL=https://host.docker.internal:9200 yarn test-provider:ocis which fails on Apple M1 chips since the @pact-foundation lib doesn't support it yet. I'm sure there's more env variables missing (further investigation in the .drone.star needed). The way to go here would be having them run successfully locally (= green tests) on master and then switch to this branch/PR and fix them

pascalwengerter avatar Apr 04 '22 08:04 pascalwengerter

We won't continue here since it's too time consuming and we are not happy with the parsing overall. Will discussed with: https://github.com/owncloud/owncloud-sdk/issues/1036

lookacat avatar Apr 05 '22 09:04 lookacat