owncloud-design-system icon indicating copy to clipboard operation
owncloud-design-system copied to clipboard

Fix a11y issues from release 7.1.3

Open kulmann opened this issue 4 years ago • 4 comments

DO NOT MERGE

This PR fixes the following a11y issues, branching off from version 7.1.3

Related fixes:

  • https://github.com/owncloud/owncloud-design-system/pull/1531
  • https://github.com/owncloud/web/issues/5380 (part a so far)
  • https://github.com/owncloud/web/issues/5391
  • https://github.com/owncloud/web/issues/5387

kulmann avatar Jul 23 '21 10:07 kulmann

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

update-docs[bot] avatar Jul 23 '21 10:07 update-docs[bot]

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

:white_check_mark: pascalwengerter
:white_check_mark: lookacat
:white_check_mark: kulmann
:x: Steve Frenzel


Steve Frenzel seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jan 25 '22 17:01 CLAassistant

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.3 out of 4 committers have signed the CLA.white_check_mark lookacatwhite_check_mark kulmannwhite_check_mark pascalwengerterx Steve Frenzel Steve Frenzel seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it.

@kulmann how do we handle this? Steve had originally signed the CLA and we have commits by him on master also, not sure why it fails now

pascalwengerter avatar Jan 25 '22 17:01 pascalwengerter

@kulmann how do we handle this? Steve had originally signed the CLA and we have commits by him on master also, not sure why it fails now

CLA was originally signed at the time when the commits were made and we won't be able to cherry-pick any of this to master anyway. So IMO it just looks ugly on this PR now, which is only cosmetic.

kulmann avatar Jan 25 '22 22:01 kulmann