Collection OCM Bugs and refinements (WIP)

[tbsbdr]

Collection

as discussed today; needs refinement - work in progress. writing down notes here for better visibility. (ticket is not yet actionable). some items might be obsolete due to @ScharfViktor s work. if so, please ignore them.

Most important Issues on top (imo):

Urgent and important:

• [x] https://github.com/owncloud/ocis/issues/9745
  • [x] libre graph query added in https://github.com/owncloud/libre-graph-api/pull/191
  • [x] api changes implemented in https://github.com/owncloud/ocis/pull/9765
  • [x] web external/internal switch https://github.com/owncloud/web/pull/11351
• [x] https://github.com/owncloud/ocis/issues/9747
  • [x] libre graph spec change added with https://github.com/owncloud/libre-graph-api/pull/190
  • [x] api changes implemented in https://github.com/owncloud/ocis/pull/9788
  • [x] web: https://github.com/owncloud/web/issues/11361
• [x] https://github.com/owncloud/ocis/pull/9778
• [x] New variable like OCIS_ENABLE_OCM should summarize most of the variable to simplify enablement of ocm https://github.com/owncloud/ocis/pull/9784
• [ ] add documentation (admin & user)
  • readme update in https://github.com/owncloud/ocis/pull/9814
  • [ ] api description needs rework? maybe just reference external documentation as sciencemesh is a different project.
• [x] ~~Rename ScienceMesh App~~
  • jfd: to what? Isn't thisn specific to the sciencemesh? so ... why rename?
  • tbsbdr: hm.. yes, agree. the idea was to make it more generic eg. for non-scientific usecases (school, eu-governments etc.) but lets keep it as is for now and bring it up again if requested.
  • jfd: maybe sciencemesh? to make it more specific? I'd prefer to use a spaces based solution for our generic federated sharing. IMO we can and should leave public link based sharing behind.
• [x] ~~Rename "Institution"~~
  • jfd: to what? Maybe 'Domain'? Migth be too technical ... on the other hand might ok for the target audience. We might have to check the Sciencemesh conepts and naming. Then again: why rename if this is a sciencemash specific term anyway?
  • tbsbdr: same like above.
  • jw: the term "institution" is "the ocmprovider of the invitation" - The equivalence of these terms is no where to be seen. This adds confusion.
  • jfd: I found the docs for the GOCDB site object, which has a domain property that has to match the domain in the config ... without a protocol.
• [x] invite grantedTo should get an @libreGraph indicator for the user type
• [x] /permissions endpoint does not return federated shares (https://github.com/owncloud/ocis/issues/9898)

---

Later, not so urgent:

• [x] https://github.com/owncloud/ocis/issues/9908
• [x] Shares: Shared with me: Avatars should be visible
  • permissions of an ocm share doeas not have a roles property
• [x] Shared with me filtering by type federated does not work
• [x] #9806
• [x] owncloud/web#11358
• [x] sciencemesh generate token does not show expiry date
• [x] #10014
• [ ] desktop (and mobile clients): do not sync.
  • maybe because we did not provide an etag. might be fixed with https://github.com/cs3org/reva/pull/4823
• [x] #9926
• [x] https://github.com/owncloud/ocis/issues/9583
• [x] #9927
  • store uuid mapping in ocm
  • populate user identities with correct issuer + remoteid
• [ ] test what happens when two federated shares with the same name are created. how does the propfind look? do we deduplicate the names?
• [ ] Shares: "Hide" returns an error
• [ ] Shares: "Disable Sync" returns an error - requires implementing mountpoints
• [ ] https://github.com/owncloud/ocis/issues/9591
• [ ] deleting a federated connection in the sciencemesh app has no effect. returns a 200OK response but reloading the app still shows the connection (https://github.com/owncloud/ocis/issues/9555)
• [ ] https://github.com/owncloud/ocis/issues/9534 (maybe fixed by now?)
  • [ ] https://github.com/cs3org/reva/pull/4823 return etag in propfind
• [ ] configfile ocmproviders: "domain" must be robust and work regardless if with or without https or trailing slashes
  • should be fixed with https://github.com/owncloud/ocis/pull/9765/files/966b4e142272e34f904abd0d4ecc34b6a35156ee#diff-462196e0833e494a969866c68d1f714c5ca516085de07f99f5b23113d9c44334R286
  • [ ] add go cli tool to fgenerate ocmproviders.json file
• [ ] "Generate invitation" works only if there is already a ocmprovider entered
  • generating works, but the ocmproviders must be configured by the admin beforehand. if they are not ... there is no sciencemesh app anyway. or at least it should be disabled.
  • accepting the invite token requires selecting the provider, even if only one is available ... maybe preselect one?
• [ ] General: Need for OCM 2.0?
• [ ] discovery: https://github.com/cs3org/reva/pull/4809
• [x] https://github.com/owncloud/ocis/issues/10051
• [ ] https://github.com/owncloud/web/issues/11579

[tbsbdr]

Sharing

If OCM is enabled, then the search scope must be defined:

• Internal OR External users

Note: we dismissed the idea of having a mix of both user types, as they come with different permission possibilities.

[tbsbdr]

updated ocm wording (skip for now) cc @butonic

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.