ocis icon indicating copy to clipboard operation
ocis copied to clipboard

ENV VAR `FRONTEND_SEARCH_MIN_LENGTH`has a misleading name

Open AlexAndBear opened this issue 1 year ago • 2 comments

The environment variable FRONTEND_SEARCH_MIN_LENGTH currently has a name that could lead to confusion. It suggests that it defines the minimum length of the search term for file searches (our prominent search in the top bar). However, its actual functionality is to set the minimum input length for identifying share receivers. To prevent any ambiguity, I propose renaming this variable to more accurately reflect its purpose.

For reference, the current usage of this variable is documented here: Frontend Service List - ownCloud Documentation

AlexAndBear avatar Jul 22 '24 20:07 AlexAndBear

This will require deprecating this envvar for at least one version. Any suggestion into what it should be renamed?

kobergj avatar Jul 23 '24 06:07 kobergj

e.g SHARE_RECEIVER_MIN_INPUT_LENGTH

AlexAndBear avatar Jul 23 '24 20:07 AlexAndBear

Is this somewhat related to #9000. So if we change the naming here, we should use some OCIS_ name and use that variable in the graph service as well. The frontend and graph service should use the same variable to avoid stuff like described in #9000

rhafer avatar Aug 05 '24 10:08 rhafer