ocis icon indicating copy to clipboard operation
ocis copied to clipboard

ocis_full deployment example is missing to startup (at least) the notification service

Open mmattel opened this issue 1 year ago • 7 comments

While fixing an admin docs issue, I realized the following:

The notification service has been removed from automatic startup with PR 9468, currently in master, effective with rolling 6.2.0.

This leads to the situation, that we configure SMTP stuff via the envvars, but because the service is not started, it will never get used - a really hard to find issue...

We should check with the actual ocis server && ocis list command which services are started and which services we need to add to the deployment startup.

@micbar @tbsbdr @jnweiger fyi

mmattel avatar Jul 17 '24 09:07 mmattel

EDITED:

To fix this, I am thinking about a new yml that defines all additional services to be started up. This could be done with OCIS_ADD_RUN_SERVICES that requires a list of services added in ocis.yml.

The extra list of services can be defined via an envvar in .env, OCIS_ADD_RUN_SERVICES": "notifications,${OCIS_ADDITIONAL_SERVICES:-}"

Benefit:

  • start the bare minimum defined in the default ocis startup list
  • future proof if other services get removed from automatic startup
  • add any service that is necessary to be startedcan be defined via .env

mmattel avatar Jul 17 '24 10:07 mmattel

I don't understand what is going on: ocis_full by definition is an example that starts up as much as possible. ocis_mini would be an example that we may want to strip down to a bare minimum.

jnweiger avatar Jul 17 '24 10:07 jnweiger

Already done in https://github.com/owncloud/ocis/blob/master/deployments/examples/ocis_full/inbucket.yml#L6

micbar avatar Jul 17 '24 13:07 micbar

Already done in

I disagree as this is only valid if you run the inbucket container which you do not use in production where you define a real smtp environment. Even more, inbucket and a full smtp setup is mutual exclusive. We have to split therefore the use of inbucket from from how we start notifications. We have btw made explicit comments in the .env file about when to use what:

ocis: this doesn't work if you are using inbucket inbucket: Inbucket is a mail catcher tool for testing purposes. DO NOT use in Production.

mmattel avatar Jul 17 '24 13:07 mmattel

That is my point. Inbucket shows how this can be achieved for production.

micbar avatar Jul 17 '24 14:07 micbar

Inbucket shows how this can be achieved for production.

The example should not show the capability but must be production ready. That was the goal set. The envvar needs to go into ocis.yml where I highly recommend making this configurable, see my (edited) post above.

mmattel avatar Jul 17 '24 14:07 mmattel

Yes yes yes yes ….

we will fix it, no need to create so much noise

micbar avatar Jul 17 '24 15:07 micbar