ocis icon indicating copy to clipboard operation
ocis copied to clipboard

Proxy service readme - autoprovisioning - unclear text

Open mmattel opened this issue 1 year ago • 1 comments

There are two statements in the proxy readme in section Automatic User and Group Provisioning that sound contradictionary and need clarification. This was found by @kobergj reading the admin docs PR.

This is a copy/paste of the finding:

you must ensure that the user's email address or username never changes.

Later you state:

If the user does already exist, the proxy will check if the user's email or displayname has changed and updates those accordingly via graph service.

So what is it now? Do I need to take care the email never changes or will it be updated automatically? ...

Also read additional comments in the referenced admin docs PR.

@rhafer @micbar pls help sorting this out

mmattel avatar Jul 16 '24 07:07 mmattel

I made a comment here https://github.com/owncloud/docs-ocis/pull/912#discussion_r1678915286 which might help or confuse the discussion.

phil-davis avatar Jul 16 '24 07:07 phil-davis

This is a copy/paste of the finding:

you must ensure that the user's email address or username never changes.

The full wording in the readme is:

"That means, if a claim like email or preferred_username is used, you must ensure that the user's email address or username never changes."

So that basically has some info about when the email is allowed to change and when not. Nevertheless it still seems to be confusing. I'll try clarify the readme.

what is it now? Do I need to take care the email never changes or will it be updated automatically?

as always: "it depends"

rhafer avatar Aug 05 '24 12:08 rhafer

I made a comment here owncloud/docs-ocis#912 (comment) which might help or confuse the discussion.

Your comment is exactly right. I'll try to come of with some additional working to clarify in the README

rhafer avatar Aug 05 '24 13:08 rhafer