Activity parent resource refs
Describe the bug
For most file location related activity items I'd expect the target or parent folder to be referred to in the activity message. Instead, only the space itself is referenced.
Steps to reproduce
- Create a Space
Space - Create a folder
folder - Create a subfolder
folder/subfolder - Create a file
test.mdinsidefolder - Move
test.mdtofolder/subfolder
Expected behavior
- Activity message for (3) is
admin added subfolder to folderoradmin added subfolder to folder in Space(up to @tbsbdr to decide) - Activity message for (4) is
admin added test.md to folderoradmin added test.md to folder in Space(up to @tbsbdr to decide) - Activity message for (5) is
admin moved test.md to subfolderoradmin moved test.md to subfolder in Space(up to @tbsbdr to decide)
Actual behavior
Activity messages actually are:
admin added subfolder to Spaceadmin added test.md to Spaceadmin moved test.md to Space
I've lowered the priority to p3, we can work on this in the next sprint. No immediate fixing needed.
As far as I can see it, this needs an additonal event to be thrown in that case. See https://github.com/owncloud/ocis/blob/1c4f53d774e7815b5c5217ddfc996d614c213b41/services/activitylog/pkg/service/http.go#L106-L160 and https://github.com/owncloud/ocis/blob/1c4f53d774e7815b5c5217ddfc996d614c213b41/services/activitylog/pkg/service/response.go#L22-L32