ocis icon indicating copy to clipboard operation
ocis copied to clipboard

Activity parent resource refs

Open kulmann opened this issue 1 year ago • 1 comments

Describe the bug

For most file location related activity items I'd expect the target or parent folder to be referred to in the activity message. Instead, only the space itself is referenced.

Steps to reproduce

  1. Create a Space Space
  2. Create a folder folder
  3. Create a subfolder folder/subfolder
  4. Create a file test.md inside folder
  5. Move test.md to folder/subfolder

Expected behavior

  • Activity message for (3) is admin added subfolder to folder or admin added subfolder to folder in Space (up to @tbsbdr to decide)
  • Activity message for (4) is admin added test.md to folder or admin added test.md to folder in Space (up to @tbsbdr to decide)
  • Activity message for (5) is admin moved test.md to subfolder or admin moved test.md to subfolder in Space (up to @tbsbdr to decide)

Actual behavior

Activity messages actually are:

  • admin added subfolder to Space
  • admin added test.md to Space
  • admin moved test.md to Space

kulmann avatar Jul 04 '24 12:07 kulmann

I've lowered the priority to p3, we can work on this in the next sprint. No immediate fixing needed.

kulmann avatar Jul 05 '24 03:07 kulmann

As far as I can see it, this needs an additonal event to be thrown in that case. See https://github.com/owncloud/ocis/blob/1c4f53d774e7815b5c5217ddfc996d614c213b41/services/activitylog/pkg/service/http.go#L106-L160 and https://github.com/owncloud/ocis/blob/1c4f53d774e7815b5c5217ddfc996d614c213b41/services/activitylog/pkg/service/response.go#L22-L32

dragonchaser avatar Sep 12 '24 14:09 dragonchaser