ocis icon indicating copy to clipboard operation
ocis copied to clipboard

chore: code cleanup services/web

Open DeepDiver1975 opened this issue 1 year ago • 2 comments

Description

:broom:

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Technical debt
  • [ ] Tests only (no source changes)

Checklist:

  • [ ] Code changes
  • [ ] Unit tests added
  • [ ] Acceptance tests added
  • [ ] Documentation ticket raised:

DeepDiver1975 avatar Apr 30 '24 15:04 DeepDiver1975

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

update-docs[bot] avatar Apr 30 '24 15:04 update-docs[bot]

@fschade please check that out. You are refactoring a lot in the web service.

Please make sure that you do not overlap 😬

just saying ...

micbar avatar May 10 '24 13:05 micbar

@DeepDiver1975 @fschade

Please get it merged or close.

micbar avatar Jun 04 '24 08:06 micbar

@DeepDiver1975 @fschade

Please get it merged or close.

i take care, thx

fschade avatar Jun 04 '24 08:06 fschade

@fschade I can do the rebase ....

DeepDiver1975 avatar Jun 04 '24 09:06 DeepDiver1975

@fschade I can do the rebase ....

some things changed in the meantime, the branding is now part of the theme package, backported. Waiting for the ci now.

fschade avatar Jun 04 '24 09:06 fschade

Nice! THX

DeepDiver1975 avatar Jun 04 '24 11:06 DeepDiver1975