ocis icon indicating copy to clipboard operation
ocis copied to clipboard

Assimilate `clean` command into `sessions`

Open kobergj opened this issue 10 months ago • 3 comments

ocis storage-users uploads clean cleans up unfinished uploads when executed.

ocis storage-users uploads sessions lists unfinished uploads. It takes filters to only list specific uploads (e.g. processing=true). It already has a --restart flag that restarts listed uploads. If we deprecate the clean command and add a --clean flag to the sessions command instead, we will use the same logic on both commands.

Acceptance Criteria:

  • deprecate ocis storage-users uploads clean
  • add a --clean flag and logic to sessions command
  • make sure virus infected files can be filtered in some way

kobergj avatar Apr 29 '24 11:04 kobergj

@d7oc @kobergj Should we backport this?

When it fits into a patch release, i think it would be worth a backport.

micbar avatar May 03 '24 10:05 micbar

If we want it: Full feature would need another reva release.

kobergj avatar May 03 '24 11:05 kobergj

I would really appreciate a backport.

d7oc avatar May 03 '24 11:05 d7oc

@d7oc is the current solution which is currently rolled out "good enough"? (we would prefer not to backport with efforts in mind)

tbsbdr avatar May 27 '24 09:05 tbsbdr

No backport means we would get it when according to the current planning?

d7oc avatar May 27 '24 13:05 d7oc

Still not clear if this needs to be backported. If not backported this feature will only come with ocis 6.x

@tbsbdr @d7oc please decide so I can either close this ticket or proceed with the backport

kobergj avatar Aug 14 '24 08:08 kobergj

IMHO we should do a back port. oCIS 6 will otherwise take some time.

d7oc avatar Aug 14 '24 11:08 d7oc

backport merged

kobergj avatar Sep 16 '24 12:09 kobergj