ocis icon indicating copy to clipboard operation
ocis copied to clipboard

[ocis] No SSE event to create odt file

Open ScharfViktor opened this issue 10 months ago • 4 comments

Version 5.1.0-prealpha+9c51bfe98 Web client version 9.0.0-alpha.5

ocis started using docker-compose https://github.com/owncloud/web/blob/master/docker-compose.yml

Steps:

  • admin creates space and adds einstein to the space
  • einstein opens space and wait
  • admin creates new .odt file inside of the space

Expected: einstein see .odt file without reload the page Actual: no file

https://github.com/owncloud/ocis/assets/84779829/4445d778-bde0-4016-9154-a5299f0b4d29

@kobergj @AlexAndBear I guess it's backend issue? if I'm wrong please move it to web repo

ScharfViktor avatar Apr 24 '24 11:04 ScharfViktor

I guess this is a backend issue file-Touch event should fire

AlexAndBear avatar Apr 24 '24 11:04 AlexAndBear

a couple more questions about SSE:

  1. a set of events such as editing the contents of a file, copying a file, etc. are called as postprocessing-finished . is it okay? Screenshot 2024-04-24 at 14 20 43

  2. I see that we have event for changing file content but we missed event for restoring version of the file:

https://github.com/owncloud/ocis/assets/84779829/aafcb06f-4b94-4916-b36a-f007fc0436a2

ScharfViktor avatar Apr 24 '24 12:04 ScharfViktor

I can confirm this is a backend issue. Specifically with wopi and the way it is implemented. In a nutshell the problem is that wopi only initializes the upload, but never finishes it. This works because of a loophole in decomposedfs. I need to check how old and new wopi implementations behave so we can tackle this.

Once you enter some content a "postprocessing-finished" event will be fired.

a set of events such as editing the contents of a file, copying a file, etc. are called as postprocessing-finished . is it okay?

Yes. The server cannot differentiate these actions, they are all the same to it.

I see that we have event for changing file content but we missed event for restoring version of the file:

Has never been in any ticket. Not sure if this was intentional or just forgotten. @micbar @tbsbdr should we add a sse for "item restored from trashbin"?

kobergj avatar Apr 24 '24 13:04 kobergj

For "item restored from trash" we have an event but not for versions.

Please keep in mind that we don't want to go into full detail yet with SSE and don't need to catch every case.

AlexAndBear avatar Apr 24 '24 14:04 AlexAndBear