[full-ci] POC Replacement for TokenInfo endpoint
Description
Related Issue
https://github.com/owncloud/ocis/issues/8858
Motivation and Context
How Has This Been Tested?
- test environment:
- test case 1:
- test case 2:
- ...
Screenshots (if appropriate):
Types of changes
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] Technical debt
- [ ] Tests only (no source changes)
Checklist:
- [ ] Code changes
- [ ] Unit tests added
- [ ] Acceptance tests added
- [ ] Documentation ticket raised:
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.
I'm not 100% sure here, but after a quick research I think we can't get rid of the browser auth popup when sending a 401 response code and the WWW-Authenticate header. So we might need to find a slightly different solution. Things that come to my mind:
- Changing the status code to e.g.
400(semantically not correct though). - Remove the
WWW-Authenticateheader so clients need differentiate based on the returned error message. I guess that would be okay if we don't plan to translate it.
@JammingBen I removed the WWW-Authenticate Basic header
The popup authentication also made the webUITest faled
Please try without authentication popup
@JammingBen I removed the
WWW-Authenticate Basicheader The popup authentication also made the webUITest faled Please try without authentication popup
Yup that works 👍 I'm simply checking the error message now: https://github.com/owncloud/web/pull/10869/files#diff-90681f8aba50079e5c32cf69d1f1c61af3dbf496f0adfd5fa45936a5647eb767R144. If @micbar or @rhafer don't have any objections I'm fine with that.
@2403905 This doesn't build currently. I think you need to rebase you reva fork and update the vendor files.
@2403905 Now that the reva part is merged we can rebase and remove the reva replacement.
Quality Gate passed
Issues
2 New issues
0 Accepted issues
Measures
0 Security Hotspots
50.0% Coverage on New Code
0.0% Duplication on New Code