ocis icon indicating copy to clipboard operation
ocis copied to clipboard

[full-ci] POC Replacement for TokenInfo endpoint

Open 2403905 opened this issue 1 year ago • 5 comments

Description

Related Issue

https://github.com/owncloud/ocis/issues/8858

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Technical debt
  • [ ] Tests only (no source changes)

Checklist:

  • [ ] Code changes
  • [ ] Unit tests added
  • [ ] Acceptance tests added
  • [ ] Documentation ticket raised:

2403905 avatar Apr 23 '24 07:04 2403905

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

update-docs[bot] avatar Apr 23 '24 07:04 update-docs[bot]

I'm not 100% sure here, but after a quick research I think we can't get rid of the browser auth popup when sending a 401 response code and the WWW-Authenticate header. So we might need to find a slightly different solution. Things that come to my mind:

  • Changing the status code to e.g. 400 (semantically not correct though).
  • Remove the WWW-Authenticate header so clients need differentiate based on the returned error message. I guess that would be okay if we don't plan to translate it.

JammingBen avatar May 02 '24 10:05 JammingBen

@JammingBen I removed the WWW-Authenticate Basic header The popup authentication also made the webUITest faled Please try without authentication popup

2403905 avatar May 02 '24 10:05 2403905

@JammingBen I removed the WWW-Authenticate Basic header The popup authentication also made the webUITest faled Please try without authentication popup

Yup that works 👍 I'm simply checking the error message now: https://github.com/owncloud/web/pull/10869/files#diff-90681f8aba50079e5c32cf69d1f1c61af3dbf496f0adfd5fa45936a5647eb767R144. If @micbar or @rhafer don't have any objections I'm fine with that.

JammingBen avatar May 02 '24 11:05 JammingBen

@2403905 This doesn't build currently. I think you need to rebase you reva fork and update the vendor files.

rhafer avatar May 07 '24 08:05 rhafer

@2403905 Now that the reva part is merged we can rebase and remove the reva replacement.

rhafer avatar May 14 '24 07:05 rhafer