ocis icon indicating copy to clipboard operation
ocis copied to clipboard

SharingNG: initial OCM support

Open butonic opened this issue 10 months ago • 2 comments

I just wanted to fix the CI for https://github.com/cs3org/reva/pull/4630, but to debug I had to make graph support OCM so that I could use web to actually send invites, create shares and browse them ...

This is rudimentary, only supports creating and accepting shares. It is a start ...

butonic avatar Apr 19 '24 21:04 butonic

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

update-docs[bot] avatar Apr 19 '24 21:04 update-docs[bot]

Steps:

  • run 2 ocis instance
  • in the ocis1 choose scienceMesh in the app switcher
  • generate invitation and copy invite token
  • in the ocis2 enter invite token and click accept invitation

Actual: 401 error. invitation not accepted Screenshot 2024-06-06 at 15 43 29

log: 2024-06-06T15:34:14+02:00 ERR provider not trusted error="error verifying mesh provider" pkg=rhttp request-id=oC-performance-test-INTEL/K5kV6ZCX3j-000588 service=ocm traceid=de4cb63966b1b4745ff9ca5a642b0273

ScharfViktor avatar Jun 06 '24 13:06 ScharfViktor

Steps:

  • run 2 ocis instance
  • in the ocis1 choose scienceMesh in the app switcher
  • generate invitation and copy invite token
  • in the ocis2 enter invite token and click accept invitation

Actual: 401 error. invitation not accepted Screenshot 2024-06-06 at 15 43 29

log: 2024-06-06T15:34:14+02:00 ERR provider not trusted error="error verifying mesh provider" pkg=rhttp request-id=oC-performance-test-INTEL/K5kV6ZCX3j-000588 service=ocm traceid=de4cb63966b1b4745ff9ca5a642b0273

There was config issue. no issue

@butonic can we merge this PR?

ScharfViktor avatar Jun 24 '24 09:06 ScharfViktor

Rebased. IMO we should merge this as is. It allows developers to actually set up and debug OCM shares. It will allow implementing E2E tests.

The commented code sections point out missing pieces in the CS3 API. I would merge this ASAP to iterate further.

butonic avatar Jun 24 '24 11:06 butonic