owncloud
[ocis][Sharing NG] Banned link password error message capitalization
Describe the bug
The error message when trying to use a banned password for a public link should have proper capitalization.
Steps to reproduce
- Make sure you have a list of banned passwords for public links
- Try creating a link with a banned password
Expected behavior
The error message should be Unfortunately, your password is commonly used. Please pick a harder-to-guess password for your safety.
Actual behavior
The error message is unfortunately, your password is commonly used. please pick a harder-to-guess password for your safety.
Why is this blocked?
IMHO we should not repeat the same mistake as on OCS.
@fschade We schould create a dedicated graph error type, and use the type in the web client.
We need translations for this message. There are two ways:
- Dictionary in web
- Dictionary in ocis, which would make Dictionaries in the clients obsolete.
@kulmann @dragotin FYI
Why is this blocked?
IMHO we should not repeat the same mistake as on OCS.
@fschade We schould create a dedicated graph error type, and use the type in the web client.
We need translations for this message. There are two ways:
- Dictionary in web
- Dictionary in ocis, which would make Dictionaries in the clients obsolete.
@kulmann @dragotin FYI
blocked because we’ve said errors should not care about the capitalization and we need a broader solution as described by you.
https://github.com/owncloud/ocis/pull/8733#issuecomment-2020003893
which of your ideas is preferred?
I prefer 2.), ship an ocis endpoint which provides the translated string dictionary.
Do we need a story to work on it or can I create something in the scope of this issue?
I also prefer 2 because we have translation efforts centralized and all clients could use that.
We would need some Endpoint and definition of payload.
I'd also prefer that clients can just use properly translated error messages coming from the backend. That requires proper capitalization.
on hold until:
- everyone is back from vacation
- story for that exists
- technical approach is clear
cc.: @kobergj, @JammingBen