ocis icon indicating copy to clipboard operation
ocis copied to clipboard

[QA] Sharing NG

Open micbar opened this issue 1 year ago • 3 comments

Organisational overview of all QA

Related to https://github.com/owncloud/ocis/issues/6993

Prerequisites

Start ocis with the default config.

  1. Resharing is controlled by OCIS_ENABLE_RESHARING

Recommendation: Decide before you deploy, if you change it, the existing Shares will not be converted.

New User / Group Lookup

Regular users can search for other users and groups. The following limitations apply:

  • Only search queries are allowed (using the $search=term query parameter)
  • The search term needs to have at least 3 characters
  • for user searches the result set only contains the attributes displayName, userType, mail and id
  • for group searches the result set only contains the attributes displayName, groupTypes and id

Referencing https://github.com/owncloud/ocis/issues/7782 for the qa team.

Collecting bugs:

  • https://github.com/owncloud/ocis/issues/7962

micbar avatar Dec 11 '23 13:12 micbar

After discussion with @individual-it we decided to implement the new sharing ng tests separately from the existing api tests.

adapting new api to existing tests can be complicated and slow down test development.

so we need:

  1. create a new ApiShare suite with LinkContext.php ShareContext.php and using existing graphHelper.php

  2. start to write tests for this endpoinds: https://owncloud.dev/libre-graph-api/#/roleManagement https://owncloud.dev/libre-graph-api/#/drives.permissions

  3. reuse existing cases but don't delete old tests (we'll delete them after 6 months)

  4. pay attention to permissions, security stuff (negative cases when an unauthorized or unauthorized user tries to do something)

  5. use wording appropriate to the api request like user gets sharing permissions for a file|folder

also for https://github.com/owncloud/cs3api-validator need create some positive CRUD tests:

  • create sharing invitation with all roles and all existing permissions
  • create sharing link with all roles and all existing permissions, custom name and expirity

ScharfViktor avatar Dec 12 '23 12:12 ScharfViktor

First test already created: https://github.com/owncloud/ocis/pull/7946 cc @individual-it @saw-jan

ScharfViktor avatar Dec 12 '23 16:12 ScharfViktor

QA sub issues:

  • https://github.com/owncloud/ocis/issues/7947
  • https://github.com/owncloud/ocis/issues/8111
  • https://github.com/owncloud/ocis/issues/7826
  • https://github.com/owncloud/ocis/issues/8318
  • https://github.com/owncloud/ocis/issues/8336
  • https://github.com/owncloud/ocis/issues/8008
  • https://github.com/owncloud/ocis/issues/7968
  • https://github.com/owncloud/ocis/issues/8810
  • https://github.com/owncloud/ocis/issues/8888
  • https://github.com/owncloud/ocis/issues/9046
  • https://github.com/owncloud/ocis/issues/9524

saw-jan avatar Feb 01 '24 09:02 saw-jan