[QA] Test coverage for OCM bugs

[prashant-gurung899]

Description

Reference of OCM bugs collection: https://github.com/owncloud/ocis/issues/9735

OCM setup : https://owncloud.dev/ocis/development/testing/#running-test-suite-with-federated-sharing-ocm Future Federated space concept https://github.com/owncloud/ocis/issues/10065

Bug Report

• https://github.com/owncloud/ocis/issues/10734
  • [ ] Test:
• https://github.com/owncloud/ocis/issues/10719 @prashant-gurung899
  • Tests:
    • [x] hide https://github.com/owncloud/ocis/pull/11024
    • [ ] unhide
    • [x] enable sync - https://github.com/owncloud/ocis/pull/11026
    • [ ] disable sync
• Notifications related issues and tests will be tracked in #11062)

Tests Added

• https://github.com/owncloud/ocis/issues/10223 @anon-pradip
  • Tests:
    • [x] https://github.com/owncloud/ocis/pull/11017
    • [x] edge cases: https://github.com/owncloud/ocis/pull/11161
• https://github.com/owncloud/enterprise/issues/7073 (This was a config issue)
  • [x] Coverage: https://github.com/owncloud/web/pull/12366
• https://github.com/owncloud/ocis/issues/9745
  • Test coverage tracked in https://github.com/owncloud/ocis/issues/10728
• https://github.com/owncloud/enterprise/issues/7075 @PrajwolAmatya
  • [x] Test: https://github.com/owncloud/ocis/pull/10995
• https://github.com/owncloud/ocis/issues/10216 try to find federation users after deleting federated connection
  • [x] Test: already covered in https://github.com/owncloud/ocis/pull/10224
• https://github.com/owncloud/ocis/issues/11033
  • [x] test: https://github.com/owncloud/ocis/pull/11034
• https://github.com/owncloud/ocis/issues/11022
  • Test: already exists https://github.com/owncloud/ocis/blob/c954c9064c57ccd30a8baf1c3da8a36977374484/tests/acceptance/features/apiOcm/share.feature#L1069
• https://github.com/owncloud/ocis/issues/10824 @PrajwolAmatya
  • [x] Test: https://github.com/owncloud/ocis/pull/10823
• https://github.com/owncloud/ocis/issues/10822 @PrajwolAmatya
  • [x] Test: https://github.com/owncloud/ocis/pull/10823
• https://github.com/owncloud/ocis/issues/10582 @prashant-gurung899
  • [x] Test: https://github.com/owncloud/ocis/pull/11002
• https://github.com/owncloud/ocis/issues/11054 @PrajwolAmatya
  • [x] Test: https://github.com/owncloud/ocis/pull/11056
• https://github.com/owncloud/ocis/issues/11004 @PrajwolAmatya
  • [x] Test: https://github.com/owncloud/ocis/pull/11015
  • [x] Updated error message: https://github.com/owncloud/ocis/pull/11135

[wkloucek]

@prashant-gurung899 Sorry for hijacking this issue, but are there by any chance some concurrency tests already? Something like creating two OCM shares at "the same time" (I'm not sure if we need / can achieve exact same time execution). I'd be curios if we could see something like race condition situations with the current single file JSON backend if we send multiple requests at once.

[saw-jan]

We have an open ticket for parallel sharing (but that have different use-cases than just a share).

But if it's just doing multiple shares by a single user in parallel, then maybe it's possible with the current API test setup.

[wkloucek]

Nice thanks for that information! That's what I wanted to know. 👍

[saw-jan]

Nice thanks for that information! That's what I wanted to know. 👍

So testing multiple parallel sharing by a single user will do for com? should we add such test for ocm?

[wkloucek]

So testing multiple parallel sharing by a single user will do for com? should we add such test for ocm?

Yes, if it is an easy win. If it's to much effort, we can skip it for now.

[saw-jan]

Yes, if it is an easy win. If it's to much effort, we can skip it for now.

Thanks, we will let you know

[saw-jan]

Parallel ocm sharing tests will be tracked in https://github.com/owncloud/ocis/issues/11035

[saw-jan]

~Before closing this please check that the added tests are not in the expected failure list~ maybe not because at the time when we finish tests for all bug reports, some might not be fixed

[prashant-gurung899]

• [x] hide https://github.com/owncloud/ocis/pull/11024
• [ ] unhide
• [x] enable sync - https://github.com/owncloud/ocis/pull/11026
• [ ] disable sync

Tests for unhiding shared resource aren't coverered because we still can't hide the shared resource(400 status code error). Tests written for hiding shared resources are in expected-to-fail lists.

Also, tests for disabling sync of shared resource throws error(400 status code error). See: https://github.com/owncloud/ocis/issues/10719#issuecomment-2667986780

CC @nirajacharya2

[saw-jan]

• [x] hide [tests-only][full-ci] add test to hide federated shared resource #11024[ ] unhide[x] enable sync - [tests-only][full-ci] add test to enable sync of federated shared resource #11026[ ] disable sync

Tests for unhiding shared resource aren't coverered because we still can't hide the shared resource(400 status code error). Tests written for hiding shared resources are in expected-to-fail lists.

Also, tests for disabling sync of shared resource throws error(400 status code error). See: #10719 (comment)

CC @nirajacharya2

They will be done in https://github.com/owncloud/ocis/issues/11247

[saw-jan]

Tests have been added for all mentioned bug reports. So closing here