ocis icon indicating copy to clipboard operation
ocis copied to clipboard

OCM. [QA] federated user from different instances are indistinguishable when they share the same full name

Open jnweiger opened this issue 1 year ago • 4 comments

Followup on https://github.com/owncloud/web/issues/11361

Steps to reproduce

Setup three machines with e.g.

env OCIS_DNSNAME=cat-7rc3-DATE OCIS_VERSION=v7.0.0-rc.3 ./deploy_ocis_bare_metal.sh env OCIS_DNSNAME=dog-7rc3-DATE OCIS_VERSION=v7.0.0-rc.3 ./deploy_ocis_bare_metal.sh env OCIS_DNSNAME=elf-7rc3-DATE OCIS_VERSION=v7.0.0-rc.3 ./deploy_ocis_bare_metal.sh

mutually register the machines in their ocmproviders.json; service ocis restart

At machine dog, create user carol and bob. At elf and cat, create a user bob with different mail addresses. carol invites both external bob's and they accept. When carol shares a folder, with all three bobs, the search results expose full name and email. OK But later, we cannot distinguish multiple external users "Bob Builder". (In this example one Bob is misspelled as Bpb, luckily...)

Specifically: Shares -> 'Shared with others' should clearly identify the share receivers. It should include the name of the remote instance in case of federated shares.

Shares -> 'Shared with me' should clearly identify the sharer. It should include the name of the remote instance in case of federated shares.

image


image


image


image

Expected behavior

The email should be exposed too. The name of the federated machine should show up in the details.

@hodyroff fyi.

jnweiger avatar Nov 26 '24 17:11 jnweiger

I think this is a web issue. We could use the issuer value from the identities property in the graph users response to distinguish federated users coming from different federated servers.

rhafer avatar Nov 27 '24 08:11 rhafer

I can use the issuer in the search input field, any other places don't have this information though. It seems to be missing in the permissions and the sharedWithMe responses from the server.

JammingBen avatar Dec 04 '24 13:12 JammingBen

Issuer has been added to the share input field via https://github.com/owncloud/web/pull/12002. For the rest, see my comment above. Transferring the issue to the ocis repo again because of that.

JammingBen avatar Dec 05 '24 08:12 JammingBen

We can decode the "Federated" user id to differentiate the users. Created the web ticket.

2403905 avatar Feb 17 '25 14:02 2403905

With the latest web and ocis, I see these details:

Image Image
Image Image
Image Image

If these are the desired ones, then I would like to close this issue here.

CC @LukasHirt @2403905

saw-jan avatar Apr 17 '25 10:04 saw-jan

Yep, the Web ticket is closed - https://github.com/owncloud/web/issues/12184 I do not see anything additional in this issue.

LukasHirt avatar Apr 17 '25 13:04 LukasHirt