owncloud
routes support
Description
add Route configurations for OpenShift
Related Issue
- Fixes #652
How Has This Been Tested?
- test environment: k8s,oc
Types of changes
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [x] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] Technical debt
- [ ] Tests only (no source changes)
Checklist:
- [x] Code changes
- [ ] Unit tests added
- [ ] Acceptance tests added
- [x] Documentation generated (
make docs) and committed - [ ] Documentation ticket raised:
- [ ] Documentation PR created:
@case0sh could you please check drone. The CI checks fail currently: https://drone.owncloud.com/owncloud/ocis-charts/1861/2/6
It's still failing. I guess you have to disable the check in kubeconform. See https://github.com/yannh/kubeconform#usage:
-skip string
comma-separated list of kinds or GVKs to ignore
@case0sh @d7oc I was looking at some Grafana and Bitnami Helm Charts and didn't find any Chart that supports OpenShift Routes. Can you please check if you can find a reputable Chart that has it? I always prefer to have a look at how it's done in reputable charts before adding our homebrewed variant of it.
From what I remember, we'll not gonna add routes to the oCIS chart. They can be included via https://github.com/owncloud/ocis-charts/blob/c6ef3d2de98ec5caccf00f367a42047e931e0596/charts/ocis/values.yaml#L845-L847