namespaceOverride isn't respected by all resources

[pixil98]

I was testing out the helm chart today and set the namespace override:

# -- Override the deployment namespace of all resources in this Helm chart.
namespaceOverride: cloud

When this is set most of the pods fail to create:

antivirus-5959654f7-cl9xp           1/1     Running                      0          13m
appregistry-869557ff5b-dn4kb        0/1     CreateContainerConfigError   0          13m
audit-55fc5778fd-97sp7              1/1     Running                      0          13m
authmachine-c4667b7d9-v9jdg         0/1     CreateContainerConfigError   0          13m
eventhistory-f797d8669-6tdjv        1/1     Running                      0          13m
frontend-655897df5f-wk9vq           0/1     CreateContainerConfigError   0          13m
gateway-b8546d7b7-pmhlb             0/1     CreateContainerConfigError   0          13m
graph-5f568646f-drhp2               0/1     CreateContainerConfigError   0          13m
groups-67788795f9-f2l45             0/1     CreateContainerConfigError   0          13m
nats-6f9f5bdd6d-5w9k5               1/1     Running                      0          13m
ocdav-7c67b4849f-fkf8s              0/1     CreateContainerConfigError   0          13m
ocis-redis-master-0                 0/1     CreateContainerConfigError   0          9m24s
ocs-7dc46c7f98-gbzcp                0/1     CreateContainerConfigError   0          13m
postprocessing-868bf7db4b-mq6zn     1/1     Running                      0          13m
proxy-6c6fc5dcb-2q52h               0/1     CreateContainerConfigError   0          13m
search-6668d69cfb-plr7k             0/1     CreateContainerConfigError   0          13m
settings-6765dc4958-6xrvp           0/1     CreateContainerConfigError   0          13m
sharing-67c59d8748-9ct9b            0/1     CreateContainerConfigError   0          13m
storagepubliclink-9bc596b8d-nd24r   0/1     CreateContainerConfigError   0          13m
storageshares-7f9d6c6646-zxqj5      0/1     CreateContainerConfigError   0          13m
storagesystem-5648d6b87d-ldjq7      0/1     CreateContainerConfigError   0          13m
storageusers-84ff4cd84f-p7l4k       0/1     CreateContainerConfigError   0          13m
store-67b874f65c-jwh7b              1/1     Running                      0          13m
thumbnails-776d6f9768-5qpjq         0/1     CreateContainerConfigError   0          13m
userlog-77c97ff5c4-mr87h            0/1     CreateContainerConfigError   0          13m
users-8b4c49b7b-f8qt9               0/1     CreateContainerConfigError   0          13m
web-7b76f8b856-grvmh                0/1     CreateContainerConfigError   0          13m
webdav-5c9d4d9f6-j5q9l              1/1     Running                      0          13m

This is because not all of the secrets and configmaps are created in the overridden namespace.

# Source: ocis/templates/storagesystem/secret.yaml
apiVersion: v1
kind: Secret
metadata:
  name: storage-system-jwt-secret
data:
  storage-system-jwt-secret: "....."

apiVersion: v1
kind: ConfigMap
metadata:
  name: graph
data:
  application-id: "3a3eb3dd-7751-4c4b-a79b-3e154f5e7a6e"

[pixil98]

The resources that don't get the namespace also aren't getting the expected app.kubernetes.io labels applied to them.

[wkloucek]

@d7oc has a good writeup of affected files / ressources in https://github.com/owncloud/ocis-charts/issues/358