fix the warning in main thread
while sync favorites files is failure sometimes beacase not in the main thread
BUGS & IMPROVEMENTS
- [ ] (1) Multiple deletion https://github.com/owncloud/ios/pull/1061#issuecomment-409823434
- [ ] (2) Multiselection mode with no items selected https://github.com/owncloud/ios/pull/1061#issuecomment-409824347
- [ ] (3) Selections are not cleared https://github.com/owncloud/ios/pull/1061#issuecomment-409830971
Thanks for the contribution! to be included in next 3.8.0 version.
In any case, we are working in a new project: https://github.com/owncloud/ios-app in which you can contribute as well!!
i will start a QA stage to the multiselection feature.
BUG (1)
Steps
- Tap on edit
- Select some files
- Tap on Done
- Select "Delete" (no matter if local or remote)
Current behaviour: Only is deleted the first one (locally) Expected: All selected files are deleted locally
Tested with: iOS11.4
BUG (2)
Steps
- Tap on Edit
- Tap on Done with no selection
Current: Sheet with options displayed Expected: no item was selected, so the options should not be displayed
Tested with: iOS11.4
BUG (3)
Steps
- Tap on Edit
- Select items
- Tap on Done
- Tap on Cancel (edit mode is closed)
- Tap again on Edit
Current: Previous selection remains Expected: Previous selections should be cleared after "Done"
Tested with: iOS11.4
Why is the file list moved to the right when you tap on "Edit"? i guess it is for showing the multiselection mode. The point is that blank at the left should be placed with any indicator or similar.
@dabechien will you check the bugs & improvements? in order to continue the process to improve the PR quality.
Dear All I am going to military service recently. Will not be updated in the near future Wait for the military service to come back and update it again. I hope to be a contributor to owncloud
Thanks Dabechien
2018-08-02 16:19 GMT+08:00 Jesús Recio Rincón [email protected]:
@dabechien https://github.com/dabechien will you check the bugs & improvements? in order to continue the process to improve the PR quality.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/owncloud/ios/pull/1061#issuecomment-409846086, or mute the thread https://github.com/notifications/unsubscribe-auth/AK8ESvuAzNS8hZrVeSwM9P2JV4gqL3fbks5uMrYMgaJpZM4UcS8j .
ok, thanks for your engagement. When you come back, ping us, to move forward the stuff.
do not forget that we are working in a new iOS project:
https://github.com/owncloud/ios-app https://github.com/owncloud/ios-sdk
it would be cool you to take part there!!