ios-app icon indicating copy to clipboard operation
ios-app copied to clipboard
verified publisher icon owncloud

[fix/confidential-office-pan-zoom] Fix pan/zoom issue when using confidential overlay options

Open felix-schwarz opened this issue 7 months ago • 2 comments

Description

PreviewViewController/WebViewDisplayViewController: if watermark/confidential overlays are used, QLPreviewController no longer reacts to scroll and zoom events, so use WebKit's support for QuickLook formats instead in those cases.

Testing note: test with multi-page/multi-slide documents to reproduce the issue.

Related Issue

https://github.com/owncloud/enterprise/issues/7224

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

felix-schwarz avatar May 26 '25 10:05 felix-schwarz

Check with different file previews, using the customer's Branding.plist

  • [X] PDF
  • [X] doc/docx
  • [X] ppt/pptx
  • [X] xls/xlsx
  • [x] txt
  • [x] image (png, jpeg)
  • [X] video (mp4)
  • [X] audio (mp3)

jesmrec avatar Jun 06 '25 11:06 jesmrec

(1)

I noticed the following behaviour about zooming txt files:

  • current branch with no watermark -> txt files can not be zoomed
  • current branch with watermark -> txt files can be zoomed

that means, zooming is only posible in txt if watermark is screened. For other type of files, works fine in both modes (with and without watermark)

CC @felix-schwarz

jesmrec avatar Jun 06 '25 11:06 jesmrec

@jesmrec Text files also couldn't be zoomed with the QuickLook text viewer before the change. With watermark enabled, WebKit is used instead of QuickLook - and WebKit appears to support zoom for text files.

Since this is not a regression, I'd leave it as is. If text should be zoomable in general, I'd suggest to move that to an issue and implement it separately.

felix-schwarz avatar Jun 25 '25 08:06 felix-schwarz

@jesmrec Text files also couldn't be zoomed with the QuickLook text viewer before the change. With watermark enabled, WebKit is used instead of QuickLook - and WebKit appears to support zoom for text files. Since this is not a regression, I'd leave it as is. If text should be zoomable in general, I'd suggest to move that to an issue and implement it separately.

works for me, that broke nothing and ftm, i think there is no an specific request about zooming files. The comment was about the different behaviour. We'll let it be.

approved on my side

jesmrec avatar Jun 25 '25 11:06 jesmrec