owncloud
[feature/feedback] Add Help & Support overview, clarify Feedback option
Description
- new view providing an overview of help and support options with a brief textual description, adding the forums to the mix
- for non-branded apps Settings make this view available as "Help & Support", replacing "Documentation", "Help" and "Feedback"
Related Issue
https://github.com/owncloud/enterprise/issues/6594
Screenshots (if appropriate):
| "Help & Support" in Settings | Overview |
|---|---|
Types of changes
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
for non-branded apps Settings make this view available as "Help & Contact", replacing "Documentation", "Help" and "Feedback"
Which is the expected behaviour for branded apps? customers who use to have their own email address for managing their own feedback, might be interested in keeping that flow.
I did the following test: i added to Branding.plist:
<dict>
...
<key>branding.send-feedback-address</key>
<string>[email protected]</string>
...
</dict>
the Help & Contact from vanilla app splits in 3 sections up (the ones existing before):
Documentation and Help point to (branded) URLs, but Send Feedback prompts to the survey. Shouldn't it keep the branded email address?
Don't forget that the survey names the ownCloud iOS app, that is static, non-brandable and unreachable for us. Customers shouldn't read that.
As reference, that was the implemented behaviour in the Android app, if helps:
https://github.com/owncloud/enterprise/issues/6594#issuecomment-2196818498
@jesmrec Thanks for catching this. That was a bug:
- previously there was a default value for the feedback email, but not for the feedback URL
- now it's vice versa
- therefore, when the feedback URL was set, that was preferred
- now with the default value, the URL was always used unless explicitly setting it to an empty value
The solution then was to prefer the email address now - now that it no longer has a default value. That issue is fixed with the latest commit.
The solution then was to prefer the email address now - now that it no longer has a default value. That issue is fixed with the latest commit.
that's perfect and working fine
- [X] No branding -> survey
- [X] Branding and mail -> mail
- [X] Branding and no mail -> survey