[feature/better-sidebar] Improved sidebar with account-wide search

[felix-schwarz]

Description

This PR:

• removes Quick Access from the sidebar, redistributing its prior contents as follows:
  • Recents: promoted to a top-level sidebar item
  • Favorites: promoted to a top-level sidebar item
  • Available Offline: promoted to a top-level sidebar item
  • other Quick Access items: moved as suggestions to new top-level sidebar Search item, with a dedicated Add to sidebar button that allows re-adding the previous Quick Access items as saved search
  • Saved searches now appear as top-level items in the sidebar
• adds custom user sidebar items
  • can be added via Add to sidebar
  • support drag and drop (also cross-account)
  • managed via context menu and swipe actions
• in the share extension automatically connects to the first account if only one account is in the account (superseding #1296)
• incorporates the latest SDK with important fixes

Related Issue

Screenshots (if appropriate):

Improved sidebar	Add to Sidebar items	Share Sheet auto-connect

Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[hosy]

Great new feature!

Some ideas how to improve it:

• Remove item from Quick Access section, if already added to sidebar
• add a Delete item context menu to a search side bar item

Not sure if the Search sidebar section should be expanded, if it has sub items. Maybe it could be sense to save the expanded state of all sidebar items.

What do you think @felix-schwarz ?

[hosy]

Another idea:

If a new search is active in the file list, it could make sense to add the Save search action to the toolbar, because it is easier to discover for the user.

[jesmrec]

QA checks:

• [X] Quick access removed
• [X] Options in sidebar: search, recents, av. offline
  • [x] Search
    • [x] PDF
      • [x] Add to sidebar
      • [x] Remove from sidebar
    • [x] Documents
      • [x] Add to sidebar
      • [x] Remove from sidebar
    • [x] Images
      • [x] Add to sidebar
      • [x] Remove from sidebar
    • [x] Videos
      • [x] Add to sidebar
      • [x] Remove from sidebar
    • [x] Audios
      • [x] Add to sidebar
      • [x] Remove from sidebar
  • [x] Recents
  • [x] Av. offline
• [X] Favorites in sidebar only in oC10
• [X] Folders in list with option Add to sidebar
  • [X] Add to sidebar some folders
  • [X] Remove to sidebar some folders
• [x] Files in list without option Add to sidebar

[jesmrec]

(1) [FIXED]

The Add to sidebar option allows to add the same item as many times as the user clicks on the option, having something like:

this is functionally correct and causes no side-effects. However, does it make more sense to allow adding every item only once? so, the option Add to sidebar mutates to Remove from sidebar when it's already there.

What do you think?

iPhone XR iOS 17.4.1 04e4d0bc1

[felix-schwarz]

@jesmrec Very good point. I have added a new "Remove from sidebar" action and made sure the app now shows the "Add to sidebar" and "Remove from sidebar" action as appropriate.

[jesmrec]

@jesmrec Very good point. I have added a new "Remove from sidebar" action and made sure the app now shows the "Add to sidebar" and "Remove from sidebar" action as appropriate.

done and fixed

[jesmrec]

Approved... ready to go.