ios-app icon indicating copy to clipboard operation
ios-app copied to clipboard
verified publisher icon owncloud

[feature/app-provider] App Provider support

Open felix-schwarz opened this issue 3 years ago • 1 comments

Description

Adds support for opening files in web apps and for creating new files using the App Provider API.

Related Issue

#1127

Developer Documentation

  • https://owncloud.dev/services/app-registry/apps/

Screenshots (if appropriate):

Creating new documents

Empty folder action Folder action File type picker File name entry New file
Simulator Screen Shot - iPhone 13 mini - 2022-09-08 at 11 47 57 Simulator Screen Shot - iPhone 13 mini - 2022-09-08 at 11 46 38 Simulator Screen Shot - iPhone 13 mini - 2022-09-08 at 11 48 02 Simulator Screen Shot - iPhone 13 mini - 2022-09-08 at 11 48 05 Simulator Screen Shot - iPhone 13 mini - 2022-09-08 at 11 48 09

Open document in web app

In info sheet In context menu Opened in Safari In-app In-app, with default browser option
Simulator Screen Shot - iPhone 13 mini - 2022-09-08 at 11 48 16 Simulator Screen Shot - iPhone 13 mini - 2022-09-08 at 11 52 21 Simulator Screen Shot - iPhone 13 mini - 2022-09-08 at 11 48 27 Simulator Screen Shot - iPhone 13 mini - 2022-09-19 at 12 23 30 Simulator Screen Shot - iPhone 13 mini - 2022-09-19 at 12 22 39

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

felix-schwarz avatar Sep 08 '22 09:09 felix-schwarz

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 4 committers have signed the CLA.

:white_check_mark: michaelstingl
:white_check_mark: hosy
:x: felix-schwarz
:x: Matthias Hühne

Matthias Hühne seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Sep 08 '22 09:09 CLAassistant

(1) [FIXED]

Close button is almost invisible in Dark themes, with inline editor:

Screenshot 2022-10-03 at 14 08 45

iPhoneXR 16.0.2 4b9af63aa

jesmrec avatar Oct 03 '22 12:10 jesmrec

(2) [FIXED]

  1. Download an OpenOffice file
  2. Remove device connection
  3. Select the Open in OnlyOffice (web) over the downloaded file

Current: nothing happens. Expected: some error feedback

iPhoneXR 16.0.2 4b9af63aa

jesmrec avatar Oct 03 '22 12:10 jesmrec

(3)

  1. Remove device connection
  2. Select + and New document
  3. Enter a correct name
  4. Submit

Current: Nothing happens (should be file created and waiting for connection using the offline mode?). After recovering connection, status bar shows 95% completed forever:

https://user-images.githubusercontent.com/14894746/193578292-a0d99225-10eb-46e0-89e8-61c30e73d748.MP4

iPhoneXR 16.0.2 iPadAir 15.7

4b9af63aa

jesmrec avatar Oct 03 '22 12:10 jesmrec

(4)

  1. Before building the app, select the option default-browser, to open the files in the external one (Safari)

Screenshot 2022-10-04 at 09 39 35

  1. Select Open in xxx -> file opened in Safari browser correctly
  2. Kill oC app and Safari app
  3. Reopen oC app
  4. Repeat step 2.

Current: file opened in the inline browser Expected: file opened in Safari (or default browser)

iPhoneXR 16.0.2 iPadAir 15.7

4b9af63aa

jesmrec avatar Oct 04 '22 07:10 jesmrec

(5) Missing Translation

Some translation strings are missing.

hosy avatar Oct 05 '22 11:10 hosy

@jesmrec (1), (2) and (3) are fixed as of https://github.com/owncloud/ios-app/pull/1151/commits/e8b125ec3dd0efbba0540105fa2a3c1ae2e20b2c

(4) is not a bug. The selected options in Xcode control which env variables Xcode sets for the app when it launches it. They don't persist and will only apply to the launched process. So when you relaunch the app outside Xcode, those env vars are gone and no longer apply.

@hosy (5) I looked through the strings and added those that previously weren't in Localizable.strings.

felix-schwarz avatar Oct 06 '22 16:10 felix-schwarz

(1) and (2) fixed (4) wont fix

@felix-schwarz for (3):

Option to create new document is available. When i click on it, dialog to select document type is displayed and options there are clickable but they don't trigger any action or any error. Is that expected? doesn't use to be a good UX, not getting feedback for user actions:

https://user-images.githubusercontent.com/14894746/194862653-969711f2-5936-40f8-8c5a-44a7e1893895.MP4

jesmrec avatar Oct 10 '22 12:10 jesmrec

(3) fixed in https://github.com/owncloud/ios-app/pull/1153

jesmrec avatar Oct 11 '22 15:10 jesmrec

(3) was fixed in 12.0 experimental branch, so, if the current PR is merged somewhere, the fix will be lost unless experimental is merged too. Please, take this is account.

Feature is totally approved in experimental branch.

jesmrec avatar Oct 13 '22 08:10 jesmrec

@jesmrec

(3) was fixed in 12.0 experimental branch, so, if the current PR is merged somewhere, the fix will be lost unless experimental is merged too. Please, take this is account.

Feature is totally approved in experimental branch.

That fix is in feature/new-navigation.

felix-schwarz avatar Oct 16 '22 14:10 felix-schwarz

That fix is in feature/new-navigation.

Ok, just be careful if the current branch is merged somewhere, in order not to lose that fix. I let it in your hands.

Approved.

jesmrec avatar Oct 18 '22 15:10 jesmrec

Merged into milestone/12.0 in 0a80962b27de768c31523233c75e8693d84d7dd3.

felix-schwarz avatar Dec 12 '22 17:12 felix-schwarz