gallery icon indicating copy to clipboard operation
gallery copied to clipboard

[+] Exif Description

Open 0xb0ba opened this issue 10 years ago • 28 comments

show exif description (if exists) instead filename on preview and slideshow

TODO

Designers need to figure out how to properly show that description.

  • Centred?
  • 3 lines? In this example it would just be the first line over 3 narrower lines
  • Scroller or rollover? Rollover would fill the screen with that description since we have to keep it narrow. Scroller requires 2 additional touch areas instead of an ugly scrollbar

A lot of galleries show the exif data in a side-bar.

default

default

0xb0ba avatar Oct 27 '15 11:10 0xb0ba

Thanks! We'll first need to discuss if that's something we want to add, but in the meantime, I'll just write down notes about the changes needed before this can be merged.

@jancborchardt and his team can check the design.

oparoz avatar Oct 27 '15 13:10 oparoz

Thanks for the fixes.

How long can descriptions be? I think you might need to use a different CSS style if we're talking about a paragraph.

oparoz avatar Oct 27 '15 23:10 oparoz

3 seconds as control. enough to read. then goes out to show the full picture.

0xb0ba avatar Oct 28 '15 08:10 0xb0ba

3 seconds as control. enough to read. then goes out to show the full picture.

Wait, so you mean, this is blocking the rendering of the picture? First the description is shown for 3 seconds, then it's replaced by the image and cannot be seen again?

oparoz avatar Oct 28 '15 11:10 oparoz

no, no. :) description show over pictures, and may close the necessary detail in the picture... after hide its may be show by mouse movement.

0xb0ba avatar Oct 28 '15 11:10 0xb0ba

OK, but how big can that description be? If it can be as long as it wants, we may need to limit it to maybe 2 lines and reveal the rest on hover.

oparoz avatar Oct 28 '15 12:10 oparoz

css already in one line

0xb0ba avatar Oct 28 '15 12:10 0xb0ba

Yes, but that's for the title, so it's not a problem if we're missing 10% of the filename because there isn't enough space, but if we only get one line out of 10 for a description, then it's going to be frustrating for users.

oparoz avatar Oct 28 '15 13:10 oparoz

Yes you are right. some people may be stored there stories.

0xb0ba avatar Oct 29 '15 06:10 0xb0ba

Can you provide a few samples with stories stored in EXIF data?

oparoz avatar Oct 31 '15 16:10 oparoz

No I can not. I keep a few words describing the photo.

0xb0ba avatar Nov 02 '15 09:11 0xb0ba

@demattin @setnes @patman15 Anybody with pictures with EXIF descriptions so that we can properly test this PR?

oparoz avatar Nov 02 '15 10:11 oparoz

@0xb0ba can you post a screenshot of this change so it’s easier to review?

jancborchardt avatar Nov 02 '15 10:11 jancborchardt

default

0xb0ba avatar Nov 02 '15 10:11 0xb0ba

Thanks for that @0xb0ba.

Designers need to figure out how to properly show that description.

  • Centred?
  • 3 lines? In this example it would just be the first line over 3 narrower lines
  • Scroller or rollover? Rollover would fill the screen with that description since we have to keep it narrow. Scroller requires 2 additional touch areas instead of an ugly scrollbar

A lot of galleries show the exif data in a side-bar. I think it would make it easier to show the meta-data we have.

oparoz avatar Nov 02 '15 11:11 oparoz

@oparoz, I'm not a designer. I can not answer these questions. in most cases it is the description of a few words, scroller or rollover is likely not needed.

exif data need not always. its cool in popup side-bar. description should always, especially in the slideshow.

0xb0ba avatar Nov 02 '15 12:11 0xb0ba

I’m not sure we should show it there to be honest. What’s the usecase for exif description like that, I have never seen it really. How do other photo apps approach this?

jancborchardt avatar Nov 02 '15 13:11 jancborchardt

I have never seen it really

for that they need to fill

default

0xb0ba avatar Nov 02 '15 16:11 0xb0ba

Thanks for the screenshot @0xb0ba. What happens on Picasa when you switch to portrait mode?

oparoz avatar Nov 02 '15 17:11 oparoz

default

0xb0ba avatar Nov 02 '15 18:11 0xb0ba

@oparoz Sorry, I only have loads of pictures with GPS tags but no comments ...

patman15 avatar Nov 02 '15 20:11 patman15

@patman15, gps tags its next step :)

0xb0ba avatar Nov 02 '15 21:11 0xb0ba

@0xb0ba, okidoki let me know when it's ready, I can test that. :-)

patman15 avatar Nov 02 '15 21:11 patman15

Thanks. That works quite well for landscape pictures shown in portrait mode, but would cover 1/3 of a portrait.

oparoz avatar Nov 03 '15 11:11 oparoz

It's not a problem. it hides after 3 seconds.

0xb0ba avatar Nov 03 '15 11:11 0xb0ba

The default timer is for the whole interface, so it is a problem when zooming in/out as there is a large block of text masking part of the image.

oparoz avatar Nov 03 '15 11:11 oparoz

its not problem too - https://github.com/0xb0ba/gallery/commit/add90f0939ea2a62052b6148218b17c11dd8a4ec

0xb0ba avatar Nov 03 '15 11:11 0xb0ba

what is the probability that the block will be large?

0xb0ba avatar Nov 03 '15 11:11 0xb0ba