files_mediaviewer
files_mediaviewer copied to clipboard
owncloud
Fix build warnings
When building files mediaviewer I'm getting the below warnings
warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistenc
warning [email protected]: Invalid bin entry for "sha.js" (in "sha.js").
warning Your current version of Yarn is out of date. The latest version is "1.22.0", while you're on "1.21.1".
WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).
This can impact web performance.
Assets:
files_mediaviewer.js (311 KiB)
WARNING in entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit (244 KiB). This can impact web performance.
Entrypoints:
main (311 KiB)
files_mediaviewer.js
WARNING in webpack performance recommendations:
You can limit the size of your bundles by using import() or require.ensure to lazy load some parts of your application.
For more info visit https://webpack.js.org/guides/code-splitting/
warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistenc
https://github.com/owncloud/files_mediaviewer/pull/203
warning Your current version of Yarn is out of date. The latest version is "1.22.0", wh
An issue on the system you did get these errors. Nothing we can/have to fix
WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB). This can impact web performance. Assets: files_mediaviewer.js (311 KiB)
can be ignored for now
warning [email protected]: Invalid bin entry for "sha.js" (in "sha.js").
upstream issue: https://github.com/crypto-browserify/sha.js/issues/64 - nothing to do for us
@HanaGemela Updated the docker container. This is a private container image, not on docker hub.
So please cd into releasescripts
git checkout master
git pull
cd docker
docker build -t oc_release:latest .
this should update your local image.
Apart from point 4, all fixed
no really an issue for us and our deployments -> I vote for close
no really an issue for us and our deployments
This leads to higher consumption of users data package in case they are accessing the app with them and a bit slower performance. I think opening a separate issue for it would be reasonable.
This leads to higher consumption of users data package in case they are accessing the app with them and a bit slower performance.
we are talking about an oc10 app here - oc10 already loads a hell of js and css. Optimizations on this end will have zero effect. ;-)