files_mediaviewer icon indicating copy to clipboard operation
files_mediaviewer copied to clipboard

Multiple bugs reported on oc.org

Open hurradieweltgehtunter opened this issue 5 years ago • 3 comments

There are multiple bug reports on owncloud.org in the comments: https://owncloud.org/news/good-bye-gallery-say-hi-to-the-new-media-viewer/

Could someone look into that?

hurradieweltgehtunter avatar Jan 06 '20 07:01 hurradieweltgehtunter

The comments basically revolve around one "Bug": There is no view that shows multiple tiled previews (aka Album-View, Grid-View or Gallery-View). Thus it does not replace the gallery app.

Related issues:

  • https://github.com/owncloud/files_mediaviewer/issues/102
  • https://github.com/owncloud/files_mediaviewer/issues/99

jnweiger avatar Jan 07 '20 12:01 jnweiger

Also: "With the new player 90% of my videos dont work anymore (*.avi / *.mkv), while they worked fine on the old one. The old had a volume regulator wich the new one doesnt. Why would someone replace a very good working plugin with this not even half ready player?"

hurradieweltgehtunter avatar Jan 08 '20 01:01 hurradieweltgehtunter

I think somewhat related, I'm seeing an issue on the chrome client javascript console with the latest release and the latest file_mediaviewer plugin:

files_mediaviewer_init.js?v=8eceae50c86a607ec9f9d975d41788c4:formatted:99 Uncaught TypeError: Cannot read property 'registerAction' of undefined
    at files_mediaviewer_init.js?v=8eceae50c86a607ec9f9d975d41788c4:formatted:99
    at Array.forEach (<anonymous>)
    at HTMLDocument.<anonymous> (files_mediaviewer_init.js?v=8eceae50c86a607ec9f9d975d41788c4:formatted:92)
    at j (jquery.js:3099)
    at Object.fireWith [as resolveWith] (jquery.js:3211)
    at Function.ready (jquery.js:3417)
    at HTMLDocument.I (jquery.js:3433)

It is failing on these lines:

OCA.Files.fileActions.registerAction(r),
OCA.Files.fileActions.setDefault(i, e.name)

If I wrap them in a try/catch, it runs, but I'm not sure what I'm now missing:

try {
    OCA.Files.fileActions.registerAction(r),
    OCA.Files.fileActions.setDefault(i, e.name)
} catch (e) {}

RossRogers avatar Jan 22 '20 17:01 RossRogers