docs icon indicating copy to clipboard operation
docs copied to clipboard

Document how to theme non-core app assets in app-themes

Open VicDeo opened this issue 5 years ago • 8 comments

What Needs to be Documented?

Theming apps

  1. create directory apps under your theme: owncloud/apps/theme-example/apps
  2. create a directory for the asset you want to theme under the newly created directory: owncloud/apps/theme-example/apps/files_sharing/img
  3. Put custom folder-waiting.svg into owncloud/apps/theme-example/apps/files_sharing/img

Note: do not copy the entire app, only the needed assets

Where Does This Need To Be Documented?

https://doc.owncloud.org/server/10.0/developer_manual/core/theming.html

Why Should This Change Be Made? (Optional)

To clarify app-theming for developers

What Type Of Content Change Is This? (Optional)

  • [x] New Content Addition
  • [ ] Old Content Deprecation
  • [ ] Existing Content Simplification
  • [ ] Bug Fix to Existing Content

Which Manual Does This Relate To? (Optional)

  • [ ] Admin Manual
  • [x] Developer Manual
  • [ ] User Manual
  • [ ] Android
  • [ ] iOS
  • [ ] Branded Clients
  • [ ] Desktop Client
  • [ ] Other

Ref https://github.com/owncloud/core/issues/35623

VicDeo avatar Jun 23 '19 13:06 VicDeo

@ChrisEdS can you test this and then we can document this together?

voroyam avatar Jul 22 '19 11:07 voroyam

@ChrisEdS, any progress on this one?

settermjd avatar Jul 31 '19 07:07 settermjd

Sorry, completely missed this ticket. When's the next time you'll be in the office? @settermjd

ChrisEdS avatar Jul 31 '19 10:07 ChrisEdS

Should be there on Thursday, @ChrisEdS.

settermjd avatar Aug 06 '19 07:08 settermjd

@VicDeo, it seems that https://doc.owncloud.com/server/10.2/developer_manual/core/theming.html#how-to-override-images already covers this issue?

settermjd avatar Aug 12 '19 08:08 settermjd

@ChrisEdS, does https://doc.owncloud.com/server/10.2/developer_manual/core/theming.html#how-to-override-images already covers this issue?

settermjd avatar Mar 03 '20 09:03 settermjd

@settermjd Currently it has a sample for the core assets only and it's not obvious that theming of apps is also possible it would be good to have examples for the following cases

  • any app from shipped apps apps directory
  • any app from a custom apps directory

VicDeo avatar Mar 10 '20 11:03 VicDeo

@settermjd Currently it has a sample for the core assets only and it's not obvious that theming of apps is also possible it would be good to have examples for the following cases

  • any app from shipped apps apps directory
  • any app from a custom apps directory

Thanks for the further reply, @VicDeo. I'll try and get that implemented.

settermjd avatar Mar 23 '20 07:03 settermjd