core icon indicating copy to clipboard operation
core copied to clipboard

CI cannot find Graffino/Browser-Update

Open phil-davis opened this issue 4 months ago • 6 comments

Example: https://drone.owncloud.com/owncloud/core/40283/96/12

[3/5] Fetching packages...

error Error: https://codeload.github.com/Graffino/Browser-Update/tar.gz/76efd225894bf77c411aa8cced870fe6327ac259: Request failed "404 Not Found"

https://github.com/Graffino no longer has the Browser-Update repo. It looks like it has been deleted.

Need to investigate and see if this yarn dependency is really needed/used...

phil-davis avatar Aug 20 '25 05:08 phil-davis

Let's just drop it.

DeepDiver1975 avatar Aug 20 '25 06:08 DeepDiver1975

I emailed Graffino to find out what happened. Maybe they deleted it accidentally, and will create it again. Or maybe they are going to publish it somewhere else...

If there is no useful response in a day or two, then I will make a PR to remove it.

phil-davis avatar Aug 20 '25 06:08 phil-davis

Hello @phil-davis, @DeepDiver1975

I was under the impression from a commit a while ago that OwnCloud has moved away from Browser Update.

I've restored it.

Let me know if you're keeping it or dropping it.

I don't think that's still needed. Checking for IE and old Safari versions shouldn't be needed anymore...

But then again, it doesn't cost me nothing to keep it up. I'll be more careful when cleaning up in the future.

zenopopovici avatar Aug 20 '25 07:08 zenopopovici

I don't think that's still needed. Checking for IE and old Safari versions shouldn't be needed anymore...

That is indeed a valid statement. Let me evaluate and I will get back asap.

Thanks a lot for your fast feedback and action @zenopopovici 👍

DeepDiver1975 avatar Aug 20 '25 08:08 DeepDiver1975

CI passed for #41392 so all is good from that PoV.

@DeepDiver1975 let me know if you want me to make a PR removing this anyway.

phil-davis avatar Aug 20 '25 08:08 phil-davis

@DeepDiver1975 let me know if you want me to make a PR removing this anyway.

lets drop it - thanks @phil-davis

DeepDiver1975 avatar Oct 21 '25 10:10 DeepDiver1975