core icon indicating copy to clipboard operation
core copied to clipboard

Add type checks to SFTP.php

Open harrykipper opened this issue 1 year ago • 5 comments

Description

Adds a type check

Related Issue

Fixes https://github.com/owncloud/core/issues/41159

Motivation and Context

Removes errors from the log

How Has This Been Tested?

  • test environment: large 1000+ users installation

Screenshots (if appropriate):

Types of changes

  • [X ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Database schema changes (next release will require increase of minor version instead of patch)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Technical debt
  • [ ] Tests only (no source changes)

Checklist:

  • [X ] Code changes
  • [ ] Unit tests added
  • [ ] Acceptance tests added
  • [ ] Documentation ticket raised:
  • [ ] Changelog item, see TEMPLATE

harrykipper avatar Apr 26 '24 09:04 harrykipper

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

update-docs[bot] avatar Apr 26 '24 09:04 update-docs[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 26 '24 09:04 CLAassistant

@harrykipper please bring this to a mergable condition. THX

DeepDiver1975 avatar Jun 11 '24 12:06 DeepDiver1975

@harrykipper commit messages need to conform to https://www.conventionalcommits.org/en/v1.0.0/

A changelog needs to be added here.

You started this PR directly from the master branch in your fork. I suggest that you use a different branch(es) for making PRs and keep the master in your fork up-to-date with core master.

phil-davis avatar Aug 28 '24 15:08 phil-davis

A changelog needs to be added here.

Can be pulled from #41309

iasdeoupxe avatar Sep 05 '24 21:09 iasdeoupxe