core icon indicating copy to clipboard operation
core copied to clipboard

chore: migrate to symfony/mailer

Open DeepDiver1975 opened this issue 2 years ago • 12 comments

Description

Related Issue

  • Fixes https://github.com/owncloud/core/issues/40564

QA Scenarios

Scenarios

  • try to send mail from admin section
  • send invite via CalDAV

Mail Setups to test

  • send mail
  • qmail
  • smtp with ssl
  • smtp without ssl

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Database schema changes (next release will require increase of minor version instead of patch)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Technical debt
  • [ ] Tests only (no source changes)

Checklist:

  • [ ] Code changes
  • [ ] Unit tests added
  • [ ] Acceptance tests added
  • [ ] Documentation ticket raised:
  • [ ] Changelog item, see TEMPLATE

DeepDiver1975 avatar Oct 04 '23 15:10 DeepDiver1975

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

update-docs[bot] avatar Oct 04 '23 15:10 update-docs[bot]

@mmattel we have dropped one config setting - also the admin ui looks a bit different now ..... In addition the smtp encryption option is now either 'ssl/tls' or 'none' .... 'STARTTLS' has been dropped

DeepDiver1975 avatar Oct 05 '23 10:10 DeepDiver1975

smtp encryption option is now either 'ssl/tls' or 'none' .... 'STARTTLS' has been dropped

Same as written in the code comment above, this is a release notes thing and needs mentioning there --> @pako81

mmattel avatar Oct 05 '23 12:10 mmattel

the admin ui looks a bit different now

Can one drop me a screenshot we can use for docs into: https://github.com/owncloud/docs-server/issues/1137 ? and clarify for which version this change is targeted?

@pako81 @jnweiger fyi

mmattel avatar Oct 05 '23 12:10 mmattel

@individual-it @phil-davis can I ask you for a quick look - THX a lot: image image

DeepDiver1975 avatar Oct 05 '23 13:10 DeepDiver1975

The failing case is that sendmail is set as the mode but no sendmail is installed/configured on the system (/usr/sbin/sendmail -bs). Looks like the exception is thrown but does not cause occ to return 1 as exit code

individual-it avatar Oct 06 '23 03:10 individual-it

This can wait for merge until release-10.13.2 is out of the way, so we have time to discuss what happens for releases after doing this change for the PHP 7.4 code base - will it be "the usual" 10.14.0 minor version bump, and we work out how to address backward-compatibility issues (for example, that any real backward-compatibility issues can be handled OK for any apps that are affected).

Or would this cause a major version bump, forcing an 11.0.0 release that supports PHP 7.4...

phil-davis avatar Oct 09 '23 06:10 phil-davis

From my understanding oc11 is php8.2 We can also merge this or into the php8.2 pr

DeepDiver1975 avatar Oct 09 '23 07:10 DeepDiver1975

I suppose this is blocked/stalled for now. Can't easily be part of 10.14 because of backward-compatibility issues that are not easily avoided.

phil-davis avatar Feb 05 '24 11:02 phil-davis

I planned to do this as part of #40981 :shrug:

DeepDiver1975 avatar Feb 05 '24 11:02 DeepDiver1975