core icon indicating copy to clipboard operation
core copied to clipboard

Added "Continue" link to error page (#40909)

Open mijarena opened this issue 1 year ago • 6 comments

Description

Related Issue

  • #40909

Motivation and Context

User can quickly return to the starting page when encountering an error.

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

image

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Database schema changes (next release will require increase of minor version instead of patch)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Technical debt
  • [ ] Tests only (no source changes)

Checklist:

  • [x] Code changes
  • [ ] Unit tests added
  • [ ] Acceptance tests added
  • [ ] Documentation ticket raised:
  • [ ] Changelog item, see TEMPLATE

mijarena avatar Aug 07 '23 13:08 mijarena

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

update-docs[bot] avatar Aug 07 '23 13:08 update-docs[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 07 '23 13:08 CLAassistant

Fixed on 403 page, too

mijarena avatar Aug 11 '23 12:08 mijarena

Sidenote: The string "Logged in user must be an admin" seems to be untranslated. Can we make that eligible for translation too?

jnweiger avatar Aug 11 '23 14:08 jnweiger

I made this to be working correctly So it could be an accepted feature for the next release. I planed to polish code, style and translation next during beta.

mijarena avatar Aug 13 '23 19:08 mijarena