core icon indicating copy to clipboard operation
core copied to clipboard

[QA] users' name order is random on suggestion, for same value when sharing with multiple users

Open grgprarup opened this issue 3 years ago • 2 comments

Steps to reproduce

  1. Create user alice, brian, carol
  2. As user alice create a folder/file
  3. Open sharing dialog
  4. Fill the text field in User and Groups with the value brian,carol

Expected behaviour

It would be better if shown in the same order as of input. briancarol Note: The issue is only about the preview in the popup. No errors occur when submitting the list. The random behavior gives problems in tests added in PR https://github.com/owncloud/core/pull/40546.

Actual behaviour

The order of the user gets changed when re-input the value or erasing and type again briancarol carolbrian

grgprarup avatar Dec 20 '22 09:12 grgprarup

I can't reproduce this manually - I tried all sorts of deleting and typing in different orders, The popup always has the list of usernames in the same order as what I typed.

Anyway, IMO, the UI is not broken if the list of usernames in the popup get displayed in some different order. Users are not going to have any problem choosing the displayed item.

So we should make the tests more flexible. When the test looks for the expected popup item, it can find the text in the popup and then compare in a way that does not depend on the order of usernames in the text.

phil-davis avatar Dec 29 '22 04:12 phil-davis

I can't reproduce this manually - I tried all sorts of deleting and typing in different orders, The popup always has the list of usernames in the same order as what I typed.

Anyway, IMO, the UI is not broken if the list of usernames in the popup get displayed in some different order. Users are not going to have any problem choosing the displayed item.

So we should make the tests more flexible. When the test looks for the expected popup item, it can find the text in the popup and then compare in a way that does not depend on the order of usernames in the text.

Thank you @phil-davis . I will adjust the test implementation according to that.

grgprarup avatar Dec 29 '22 06:12 grgprarup