core icon indicating copy to clipboard operation
core copied to clipboard

[tests-only] [full-ci] Try tests with PHP 8.0

Open phil-davis opened this issue 1 year ago • 3 comments

a) CI passed for PHP 7.4 with Ubuntu 20.04 b) I have just pushed the commits to run tests with PHP 8.0

https://php.watch/versions/8.0

phil-davis avatar Aug 31 '22 05:08 phil-davis

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarcloud[bot] avatar Aug 31 '22 06:08 sonarcloud[bot]

https://drone.owncloud.com/owncloud/core/36698/7/6 phan with PHP 8.0 finds:

lib/private/Memcache/APCu.php:62 PhanUndeclaredClassMethod Call to method __construct from undeclared class \APCIterator (Did you mean to configure a stub with https://github.com/phan/phan/wiki/How-To-Use-Stubs#internal-stubs or to enable the extension providing the class. or class \APCUIterator)
lib/private/legacy/image.php:623 PhanTypeMismatchArgumentInternalReal Argument 1 ($image) is $this->resource of type resource but \imagealphablending() takes \GdImage
lib/private/legacy/image.php:624 PhanTypeMismatchArgumentInternalReal Argument 1 ($image) is $this->resource of type resource but \imagesavealpha() takes \GdImage
lib/private/legacy/image.php:723 PhanTypeMismatchArgumentInternalReal Argument 1 ($image) is $process of type false but \imagedestroy() takes \GdImage
lib/private/legacy/image.php:737 PhanTypeMismatchArgumentInternalReal Argument 1 ($image) is $process of type false but \imagedestroy() takes \GdImage
lib/private/legacy/image.php:781 PhanTypeMismatchArgumentInternalReal Argument 1 ($image) is $process of type false but \imagedestroy() takes \GdImage
lib/private/legacy/image.php:795 PhanTypeMismatchArgumentInternalReal Argument 1 ($image) is $process of type false but \imagedestroy() takes \GdImage
lib/private/legacy/image.php:820 PhanTypeMismatchArgumentInternalReal Argument 1 ($image) is $process of type false but \imagedestroy() takes \GdImage
lib/private/legacy/image.php:834 PhanTypeMismatchArgumentInternalReal Argument 1 ($image) is $process of type false but \imagedestroy() takes \GdImage
lib/private/legacy/image.php:967 PhanTypeMismatchArgumentInternalReal Argument 1 ($codepoint) is $lastIndex of type '\x00' but \chr() takes int

ToDo: investigate and adjust.

phil-davis avatar Aug 31 '22 08:08 phil-davis

https://drone.owncloud.com/owncloud/core/36713/9/6 There are no more "deprecation" warnings - that is good. But:

tests/drone/test-phpunit.sh: line 79:    25 Segmentation fault      (core dumped) $phpunit_cmd --configuration phpunit-autotest.xml ${GROUP} --coverage-clover output/coverage/autotest-clover-"${DB_TYPE}".xml

It gets nearly half-way through the unit tests and crashes. So I don't get to see what the errors actually are - just lots of tests that have "E".

phil-davis avatar Sep 01 '22 10:09 phil-davis