core feat: allow editing of public link shared single files

feat: allow editing of public link shared single files

Open DeepDiver1975 opened this issue 1 year ago • 13 comments

Description

Add option to share a single file via public link with write permissions

Related Issue

https://github.com/owncloud/enterprise/issues/5274

How Has This Been Tested?

:hand:

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Database schema changes (next release will require increase of minor version instead of patch)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Technical debt
[ ] Tests only (no source changes)

Checklist:

[x] Code changes
[ ] Unit tests added
[ ] Acceptance tests added
[ ] Documentation ticket raised:
[ ] Changelog item, see TEMPLATE

Aug 03 '22 14:08 DeepDiver1975

Would be good to get some acceptance test coverage on this ..... @phil-davis THX

Aug 03 '22 14:08 DeepDiver1975

Would be good to get some acceptance test coverage on this ..... @phil-davis THX

I will look in the morning.

Aug 03 '22 15:08 phil-davis

https://drone.owncloud.com/owncloud/core/36485/9/5

Firefox 103.0 (Ubuntu 0.0.0): Executed 1044 of 1046 (5 FAILED) (skipped 2) (18.099 secs / 17.734 secs)

make: *** [Makefile:203: test-js] Error 1

test-javascript failed - @DeepDiver1975 I will let you adjust those tests.

Aug 04 '22 06:08 phil-davis

https://drone.owncloud.com/owncloud/core/36485/10/7

There were 5 failures:
...

@DeepDiver1975 - I will let you sort out the PHP unit tests.

Aug 04 '22 06:08 phil-davis

The permissions handling seems a bit strange:

If I ask for 15, then I get 3:

curl -v -u aaaa:aaaa -X POST http://172.17.0.1:8080/ocs/v2.php/apps/files_sharing/api/v1/shares --data 'path=/t.txt&shareType=3&permissions=15&name=EditablePublicLink'

<?xml version="1.0"?>
<ocs>
 <meta>
  <status>ok</status>
  <statuscode>200</statuscode>
  <message/>
  <totalitems></totalitems>
  <itemsperpage></itemsperpage>
 </meta>
 <data>
  <id>1581</id>
  <share_type>3</share_type>
  <uid_owner>aaaa</uid_owner>
  <displayname_owner>Andrew Jones</displayname_owner>
  <permissions>3</permissions>
  <stime>1659687702</stime>
  <parent/>
  <expiration/>
  <token>RqOfpmsscTjwQK9</token>
  <uid_file_owner>aaaa</uid_file_owner>
  <displayname_file_owner>Andrew Jones</displayname_file_owner>
  <additional_info_owner/>
  <additional_info_file_owner/>
  <path>/t.txt</path>
  <mimetype>text/plain</mimetype>
  <storage_id>home::aaaa</storage_id>
  <storage>3238</storage>
  <item_type>file</item_type>
  <item_source>2147508369</item_source>
  <file_source>2147508369</file_source>
  <file_parent>2147506130</file_parent>
  <file_target>/t.txt</file_target>
  <name>EditablePublicLink</name>
  <url>http://172.17.0.1:8080/index.php/s/RqOfpmsscTjwQK9</url>
  <mail_send>0</mail_send>
  <attributes/>
 </data>
</ocs>

If just ask for permissions 3, then I only get 1:

curl -v -u aaaa:aaaa -X POST http://172.17.0.1:8080/ocs/v2.php/apps/files_sharing/api/v1/shares --data 'path=/t.txt&shareType=3&permissions=3&name=TestPublicLink'

<?xml version="1.0"?>
<ocs>
 <meta>
  <status>ok</status>
  <statuscode>200</statuscode>
  <message/>
  <totalitems></totalitems>
  <itemsperpage></itemsperpage>
 </meta>
 <data>
  <id>1582</id>
  <share_type>3</share_type>
  <uid_owner>aaaa</uid_owner>
  <displayname_owner>Andrew Jones</displayname_owner>
  <permissions>1</permissions>
  <stime>1659687798</stime>
  <parent/>
  <expiration/>
  <token>BDpLdhEFZmAoY8R</token>
  <uid_file_owner>aaaa</uid_file_owner>
  <displayname_file_owner>Andrew Jones</displayname_file_owner>
  <additional_info_owner/>
  <additional_info_file_owner/>
  <path>/t.txt</path>
  <mimetype>text/plain</mimetype>
  <storage_id>home::aaaa</storage_id>
  <storage>3238</storage>
  <item_type>file</item_type>
  <item_source>2147508369</item_source>
  <file_source>2147508369</file_source>
  <file_parent>2147506130</file_parent>
  <file_target>/t.txt</file_target>
  <name>TestPublicLink</name>
  <url>http://172.17.0.1:8080/index.php/s/BDpLdhEFZmAoY8R</url>
  <mail_send>0</mail_send>
  <attributes/>
 </data>
</ocs>

The webUI is asking for permissions 15, and getting back permissions 3.

Aug 05 '22 08:08 phil-davis

The permissions handling seems a bit strange:

This behavior did not really change in this PR.

Before this change when requesting 3 one would only get 1 in the response

Aug 05 '22 09:08 DeepDiver1975

Before this change when requesting 3 one would only get 1 in the response

Yes, before this change, requesting anything other than 1 resulted in 1 or an error.

So, I guess you want to keep the old behavior that requesting 3 returned permission 1 only - so that any existing clients that are "silly" and currently routinely request "3" will still get the same behavior.

Aug 05 '22 09:08 phil-davis

The code in #40269 should be passing now. I made a few comments there. The test scenario at the API level works. The webUI works manually when I use it to create Download/View/Edit public links (I can add a UI test for that "whenever" early next week)

But when I browse in a private window to a Download/View/Edit public link I just get a page that lets me download. I can upload with a curl command. But is there (going to be) a UI interface that lets me:

open the files_texteditor to edit a text file
upload to the file (choose a file on my local system and upload it, which would completely overwrite the file on the server)

(2) might be a bit tricky - the file on the server might be a LibreOffice document myDocument.odt, for example, but then the person accessing the public link uploads some png file, and now myDocument.odt actually has binary data in it that is a png image. Letting a user choose from any local file to overwrite some fixed filename on the server could have painful results.

Aug 05 '22 09:08 phil-davis

But when I browse in a private window to a Download/View/Edit public link I just get a page that lets me download. I can upload with a curl command. But is there (going to be) a UI interface that lets me:
1. open the files_texteditor to edit a text file

2. upload to the file (choose a file on my local system and upload it, which would completely overwrite the file on the server)
(2) might be a bit tricky - the file on the server might be a LibreOffice document myDocument.odt, for example, but then the person accessing the public link uploads some png file, and now myDocument.odt actually has binary data in it that is a png image. Letting a user choose from any local file to overwrite some fixed filename on the server could have painful results.

for the time being collabora is the only reasonable use case - we will enhance this over time. for testing curl is fine

Aug 05 '22 09:08 DeepDiver1975

or the time being collabora is the only reasonable use case - we will enhance this over time. for testing curl is fine

OK - I will make the UI test scenario use direct API requests to verify that the Download/View/Edit link works after being created in the UI.

Aug 05 '22 09:08 phil-davis

@DeepDiver1975 I have all the test code working in PR #40269

Can I rebase this PR and cherry-pick the test code into here?

Or you can do it.

The only code change that I need to make was https://github.com/owncloud/core/pull/40269/commits/430abcbeb8fe4d8018a7b348e87702a25a337ba9 - please have a look. After that, all tests pass.

Aug 11 '22 10:08 phil-davis