core icon indicating copy to clipboard operation
core copied to clipboard

Remember me option doesn't work

Open jvillafanez opened this issue 2 years ago • 2 comments

Steps to reproduce

  1. Install OC 10.10
  2. Disable files_external app
  3. Logout
  4. In the login page, mark the "stay logged in" checkbox (it doesn't seem too visual) and the log in

Expected behaviour

Additional cookies should be present in the browser so we can log in if needed

Actual behaviour

No new cookies are present. In particular oc_username, oc_token and oc_remember_login aren't there. The check seems to be sent to the server but, as said, no new cookies are sent from the server. This means that, if the session expires you won't be able to login automatically

Server configuration

Operating system:

Web server: apache 2.4

Database: mysql

PHP version: 7.4

ownCloud version: 10.10

Updated from an older ownCloud or fresh install: fresh install

Where did you install ownCloud from:

Signing status (ownCloud 9.0 and above):

Login as admin user into your ownCloud and access 
http://example.com/index.php/settings/integrity/failed 
paste the results into https://gist.github.com/ and puth the link here.

The content of config/config.php:

Log in to the web-UI with an administrator account and click on
'admin' -> 'Generate Config Report' -> 'Download ownCloud config report'
This report includes the config.php settings, the list of activated apps
and other details in a well sanitized form.

or 

If you have access to your command line run e.g.:
sudo -u www-data php occ config:list system
from within your ownCloud installation folder

*ATTENTION:* Do not post your config.php file in public as is. Please use one of the above
methods whenever possible. Both, the generated reports from the web-ui and from occ config:list
consistently remove sensitive data. You still may want to review the report before sending.
If done manually then it is critical for your own privacy to dilligently
remove *all* host names, passwords, usernames, salts and other credentials before posting.
You should assume that attackers find such information and will use them against your systems.

List of activated apps:

If you have access to your command line run e.g.:
sudo -u www-data php occ app:list
from within your ownCloud installation folder.

Are you using external storage, if yes which one: local/smb/sftp/...

Are you using encryption: yes/no

Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/...

LDAP configuration (delete this part if not used)

With access to your command line run e.g.:
sudo -u www-data php occ ldap:show-config
from within your ownCloud installation folder

Without access to your command line download the data/owncloud.db to your local
computer or access your SQL server remotely and run the select query:
SELECT * FROM `oc_appconfig` WHERE `appid` = 'user_ldap';


Eventually replace sensitive data as the name/IP-address of your LDAP server or groups.

Client configuration

Browser:

Operating system:

Logs

Web server error log

Insert your webserver log here

ownCloud log (data/owncloud.log)

Insert your ownCloud log here

Browser log

Insert your browser log here, this could for example include:

a) The javascript console log
b) The network log 
c) ...

jvillafanez avatar Jun 27 '22 07:06 jvillafanez

For reference, it seems that https://github.com/owncloud/core/commit/d8cde414bd13c327ec2edaf1ae38380073c93e3e is the commit that broke the feature.

jvillafanez avatar Jun 28 '22 13:06 jvillafanez

Looked like broken by ownCloud 9.1. Looked like more discussion by #26027.

ho4ho avatar Jun 29 '22 18:06 ho4ho

PR merged. Closing

jvillafanez avatar Oct 27 '22 11:10 jvillafanez