[QA] automatic update fails

[jnweiger]

Seen while testing the updater server for 10.10.0

{"reqId":"YrEDTyEfgXEsPm3SPCvN6wAAAAI","level":3,"time":"2022-06-20T23:31:28+00:00","remoteAddr":"65.108.61.163","user":"--","app":"index","method":"POST","url":"\/index.php\/occ\/upgrade","message":"Exception: {\"Exception\":\"Error\",\"Message\":\"Class 'OC_Mount_Config' not found\",\"Code\":0,\"Trace\":\"#0 \\\/var\\\/www\\\/owncloud\\\/lib\\\/private\\\/Route\\\/Router.php(399): include_once()\\n#1 \\\/var\\\/www\\\/owncloud\\\/lib\\\/private\\\/Route\\\/Router.php(151): OC\\\\Route\\\\Router->requireRouteFile()\\n#2 \\\/var\\\/www\\\/owncloud\\\/lib\\\/private\\\/Route\\\/Router.php(279): OC\\\\Route\\\\Router->loadRoutes()\\n#3 \\\/var\\\/www\\\/owncloud\\\/lib\\\/base.php(931): OC\\\\Route\\\\Router->match()\\n#4 \\\/var\\\/www\\\/owncloud\\\/index.php(54): OC::handleRequest()\\n#5 {main}\",\"File\":\"\\\/var\\\/www\\\/owncloud\\\/apps\\\/files_external\\\/appinfo\\\/routes.php\",\"Line\":31}"}

Class OC_Mount_Config belongs to the files_external app.

Expected behaviour:

• 10.7.x updates smoothly to 10.8.0, which can then be updated to 10.0.0

Reproduced identical

• using both updates.owncloud.com and a self-deployed updates server
• an ownCloud with mounted external storages and with files_external never enabled.
• when updating from the minimal community tar and the complete tar.

[jnweiger]

• The web UI then says

Automatic updating is disabled in config.php. To upgrade your instance, please use the command line updater (occ upgrade).

• occ upgrade succeeds.
• 10.8.0.4 comes up, and announces that `owncloud 10.10.0 is available.

[jnweiger]

• An update from 10.8.0.4 (after manual upgrade from 10.7.0.4) to 10.10.0 worked fine when triggered through the admin interface.
• Update from 10.8.0.4 (fresh install) to 10.10.0 also works fine.
• Update from 10.8.0.4 (via official updates.owncloud.com server) to 10.9.1.2 also works fine.
• Update from 10.9.1.2 (after update from 10.8.0.4) to 10.10.0 fails.
• Update from 10.9.1.2 (fresh install) to 10.10.0 fails.

[jnweiger]

A fully manual upgrade from 10.9.1 to 10.10.0 always works fine:

wget https://download.owncloud.com/server/stable/owncloud-complete-20220518.tar.bz2
cd /var/www/owncloud
cp -a config config-1091
mv data data-1091
cd ..
tar xf ~/owncloud-complete-20220518.tar.bz2 
chown -R www-data. owncloud
cd owncloud/
mv data-1091 data
mv config config-tar10100
mv config-1091 config
occ upgrade

ownCloud or one of the apps require upgrade - only a limited number of commands are available
You may use your browser or the occ upgrade command to do the upgrade
2022-06-23T13:22:44+00:00 Set log level to debug
2022-06-23T13:22:44+00:00 Turned on maintenance mode
2022-06-23T13:22:44+00:00 Repair step: Upgrade app code from the marketplace
2022-06-23T13:22:44+00:00 Repair info: Using market to update existing apps
2022-06-23T13:22:44+00:00 Repair info: Attempting to update the following existing compatible apps from market: activity, comments, configreport, dav, federatedfilesharing, federation, files, files_external, files_mediaviewer, files_pdfviewer, files_sharing, files_texteditor, files_trashbin, files_versions, firstrunwizard, market, notifications, provisioning_api, systemtags, templateeditor, updatenotification
2022-06-23T13:22:44+00:00 Repair info: Fetching app from market: activity
2022-06-23T13:22:44+00:00 Repair info: 
2022-06-23T13:22:44+00:00 Repair info: Fetching app from market: comments
2022-06-23T13:22:44+00:00 Repair info: App (comments) is not known at the marketplace.
2022-06-23T13:22:44+00:00 Repair info: Fetching app from market: configreport
2022-06-23T13:22:44+00:00 Repair info: App (configreport) is not known at the marketplace.
2022-06-23T13:22:44+00:00 Repair info: Fetching app from market: dav
2022-06-23T13:22:44+00:00 Repair info: App (dav) is not known at the marketplace.
2022-06-23T13:22:44+00:00 Repair info: Fetching app from market: federatedfilesharing
2022-06-23T13:22:44+00:00 Repair info: App (federatedfilesharing) is not known at the marketplace.
2022-06-23T13:22:44+00:00 Repair info: Fetching app from market: federation
2022-06-23T13:22:44+00:00 Repair info: App (federation) is not known at the marketplace.
2022-06-23T13:22:44+00:00 Repair info: Fetching app from market: files
2022-06-23T13:22:44+00:00 Repair info: App (files) is not known at the marketplace.
2022-06-23T13:22:44+00:00 Repair info: Fetching app from market: files_external
2022-06-23T13:22:44+00:00 Repair info: App (files_external) is not known at the marketplace.
2022-06-23T13:22:44+00:00 Repair info: Fetching app from market: files_mediaviewer
2022-06-23T13:22:44+00:00 Repair info: 
2022-06-23T13:22:44+00:00 Repair info: Fetching app from market: files_pdfviewer
2022-06-23T13:22:44+00:00 Repair info: 
2022-06-23T13:22:44+00:00 Repair info: Fetching app from market: files_sharing
2022-06-23T13:22:44+00:00 Repair info: App (files_sharing) is not known at the marketplace.
2022-06-23T13:22:44+00:00 Repair info: Fetching app from market: files_texteditor
2022-06-23T13:22:44+00:00 Repair info: 
2022-06-23T13:22:44+00:00 Repair info: Fetching app from market: files_trashbin
2022-06-23T13:22:44+00:00 Repair info: App (files_trashbin) is not known at the marketplace.
2022-06-23T13:22:44+00:00 Repair info: Fetching app from market: files_versions
2022-06-23T13:22:44+00:00 Repair info: App (files_versions) is not known at the marketplace.
2022-06-23T13:22:44+00:00 Repair info: Fetching app from market: firstrunwizard
2022-06-23T13:22:44+00:00 Repair info: App (firstrunwizard) is not known at the marketplace.
2022-06-23T13:22:44+00:00 Repair info: Fetching app from market: market
2022-06-23T13:22:44+00:00 Repair info: 
2022-06-23T13:22:44+00:00 Repair info: Fetching app from market: notifications
2022-06-23T13:22:44+00:00 Repair info: App (notifications) is not known at the marketplace.
2022-06-23T13:22:44+00:00 Repair info: Fetching app from market: provisioning_api
2022-06-23T13:22:44+00:00 Repair info: App (provisioning_api) is not known at the marketplace.
2022-06-23T13:22:44+00:00 Repair info: Fetching app from market: systemtags
2022-06-23T13:22:44+00:00 Repair info: App (systemtags) is not known at the marketplace.
2022-06-23T13:22:44+00:00 Repair info: Fetching app from market: templateeditor
2022-06-23T13:22:44+00:00 Repair info: 
2022-06-23T13:22:44+00:00 Repair info: Fetching app from market: updatenotification
2022-06-23T13:22:44+00:00 Repair info: App (updatenotification) is not known at the marketplace.
2022-06-23T13:22:44+00:00 Repair info: App was not updated: activity
2022-06-23T13:22:44+00:00 Repair info: App was not updated: comments
2022-06-23T13:22:44+00:00 Repair info: App was not updated: configreport
2022-06-23T13:22:44+00:00 Repair info: App was not updated: dav
2022-06-23T13:22:44+00:00 Repair info: App was not updated: federatedfilesharing
2022-06-23T13:22:44+00:00 Repair info: App was not updated: federation
2022-06-23T13:22:44+00:00 Repair info: App was not updated: files
2022-06-23T13:22:44+00:00 Repair info: App was not updated: files_external
2022-06-23T13:22:44+00:00 Repair info: App was not updated: files_mediaviewer
2022-06-23T13:22:44+00:00 Repair info: App was not updated: files_pdfviewer
2022-06-23T13:22:44+00:00 Repair info: App was not updated: files_sharing
2022-06-23T13:22:44+00:00 Repair info: App was not updated: files_texteditor
2022-06-23T13:22:44+00:00 Repair info: App was not updated: files_trashbin
2022-06-23T13:22:44+00:00 Repair info: App was not updated: files_versions
2022-06-23T13:22:44+00:00 Repair info: App was not updated: firstrunwizard
2022-06-23T13:22:44+00:00 Repair info: App was not updated: market
2022-06-23T13:22:44+00:00 Repair info: App was not updated: notifications
2022-06-23T13:22:44+00:00 Repair info: App was not updated: provisioning_api
2022-06-23T13:22:44+00:00 Repair info: App was not updated: systemtags
2022-06-23T13:22:44+00:00 Repair info: App was not updated: templateeditor
2022-06-23T13:22:44+00:00 Repair info: App was not updated: updatenotification
2022-06-23T13:22:44+00:00 Repair step: Repair MySQL database engine
2022-06-23T13:22:44+00:00 Repair step: Repair MySQL collation
2022-06-23T13:22:44+00:00 Repair info: Change collation for oc_migrations ...
2022-06-23T13:22:44+00:00 Repair step: Repair SQLite autoincrement
2022-06-23T13:22:44+00:00 Repair step: Repair orphaned reshare
2022-06-23T13:22:44+00:00 Repair step: Repair duplicate entries in oc_lucene_status
2022-06-23T13:22:44+00:00 Repair info: lucene_status table does not exist -> nothing to do
2022-06-23T13:22:44+00:00 Updating database schema
2022-06-23T13:22:44+00:00 Updated database
2022-06-23T13:22:44+00:00 Updating <activity> ...
2022-06-23T13:22:44+00:00 Updated <activity> to 2.7.0
2022-06-23T13:22:45+00:00 Updating <files_external> ...
2022-06-23T13:22:45+00:00 Updated <files_external> to 0.9.0
2022-06-23T13:22:45+00:00 Repair step: Repair mime types
2022-06-23T13:22:45+00:00 Repair step: Detect file cache entries with path that does not match parent-child relationships
2022-06-23T13:22:45+00:00 Repair step: Generate ETags for file where no ETag is present.
2022-06-23T13:22:45+00:00 Repair info: ETags have been fixed for 0 files/folders.
2022-06-23T13:22:45+00:00 Repair step: Clean tags and favorites
2022-06-23T13:22:45+00:00 Repair info: 0 tags of deleted users have been removed.
2022-06-23T13:22:45+00:00 Repair info: 0 tags for delete files have been removed.
2022-06-23T13:22:45+00:00 Repair info: 0 tag entries for deleted tags have been removed.
2022-06-23T13:22:45+00:00 Repair info: 0 tags with no entries have been removed.
2022-06-23T13:22:45+00:00 Repair step: Drop old database tables
2022-06-23T13:22:45+00:00 Repair step: Drop old background jobs
2022-06-23T13:22:45+00:00 Repair step: Remove getetag entries in properties table
2022-06-23T13:22:45+00:00 Repair info: Removed 0 unneeded "{DAV:}getetag" entries from properties table.
2022-06-23T13:22:45+00:00 Repair step: Repair invalid shares
2022-06-23T13:22:45+00:00 Repair step: Repair sub shares
2022-06-23T13:22:45+00:00 Repair step: Remove old share propagation app entries
2022-06-23T13:22:45+00:00 Repair step: Move user avatars outside the homes to the new location
2022-06-23T13:22:45+00:00 Repair info: No action required
2022-06-23T13:22:45+00:00 Repair step: Fix user avatars location
2022-06-23T13:22:45+00:00 Repair info: No action required
2022-06-23T13:22:45+00:00 Repair step: Remove shares of a users root folder
2022-06-23T13:22:45+00:00 Repair step: Repair unmerged shares
2022-06-23T13:22:45+00:00 Repair step: Disable extra themes
2022-06-23T13:22:45+00:00 Starting code integrity check...
2022-06-23T13:22:48+00:00 Finished code integrity check
2022-06-23T13:22:48+00:00 Update successful
2022-06-23T13:22:48+00:00 Turned off maintenance mode
2022-06-23T13:22:48+00:00 Reset log level

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

[github-actions[bot]]

This issue has been automatically closed.

[pako81]

To be verified once latest core version is available over the online updater.

[jnweiger]

Enhancement idea:

• When the enterprise theme (or when an enterprise key) is installed,
  • this web-updater should be disabled. config->getSystemValue('upgrade.disable-web', false) === true
  • Only a link to documentation should be shown. See https://doc.owncloud.com/server/next/admin_manual/maintenance/upgrading/upgrade.html#upgrade-options

[IljaN]

@jnweiger What are the next steps here? Should we implement the suggestions?

[pako81]

Proposed something at https://github.com/owncloud/core/pull/40841