Remove session-handing from loadApps

[IljaN]

Description

Remove auth code from loadApps as this shouldn't be handled there. From what we can see the code is not needed.

Related Issue

• Fixes https://github.com/owncloud/core/issues/34524
• Fixes https://github.com/owncloud/enterprise/issues/4950

Motivation and Context

Before this PR a unique constraint violation can be caused with SAML. Continuation of https://github.com/owncloud/core/pull/31782

How Has This Been Tested?

• test environment:
• test case 1:
• test case 2:
• ...

Types of changes

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Database schema changes (next release will require increase of minor version instead of patch)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [x] Technical debt
• [ ] Tests only (no source changes)

Checklist:

• [x] Code changes
• [ ] Unit tests added
• [ ] Acceptance tests added
• [ ] Documentation ticket raised:
• [ ] Changelog item, see TEMPLATE

[update-docs[bot]]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[IljaN]

Should we re-add this? https://github.com/owncloud/core/pull/31761/commits/310ddc805b27f824cc9034bf2f7acacd37ba6584

[sonarqubecloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[DeepDiver1975]

From my pov this code exists for a reason ... removing is kind of scary ...

The critical path here is that getToken and createToken are not atomic operations on db.

The solution would be to merge this into one function like getOrCreateToken so that we can implement this as an atomic operation on sql

[IljaN]

The solution would be to merge this into one function like getOrCreateToken so that we can implement this as an atomic operation on sql

Yes also thought about the "upsert" idea, could there be security issue from your pov?

[cdamken]

Any news here?

[phil-davis]

@IljaN @DeepDiver1975 see ping above ^

[IljaN]

Didn't work on this anymore