core
core copied to clipboard
apps/files_external/3rdparty is big
In apps/files_external
there is a folder called 3rdparty
which has the various special PHP dependencies. We actually composer install
and commit the source code of all those dependencies. It is big:
$ du -hs apps/files_external/3rdparty
86M apps/files_external/3rdparty
And that ends up in core release tarballs.
If we don't commit the actual dependency code, then:
- builds and tests etc have to do
composer install
in that folder as part of make - the release build has to do
composer install
and "bundle" them into the release tarball anyway
So maybe it does not make a difference that we commit all these files in the core repo?
Or maybe the files_external
app could be unbundled and made a separate app, then it would not take up this space in core release tarballs?
I noticed all this again when doing dependabot PR #39567 and make a few comments there.
Thought/comments/opinions welcome.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.
This issue has been automatically closed.