encryption becomes active before choosing type of encryption

[jnweiger]

Seen in 10.9.1RC1 with encryption 1.5.1 - (while investigating into https://github.com/owncloud/core/issues/39663#issuecomment-1008854941)

• admin has a shared file with user01, both have edited the file
• admin enables encryption

---

---

The encryption app is not yet enabled and has no encryption app menu anywhere else in the admin UI. We cannot chose the module yet, we have to first enable the app.

• admin visits the apps -> disabled page and enables encryption there too

---

• [In this state, nobody should edit any files, otherwise we trigger similar situations as #39663 ]
• To complete the setup, admin must go back to settings -> encryption
• admin chooses master key encrpytion, (as user key encryption is not supported)

Now all users can continue editing, without breaking the encrption engine.

Expected behaviour:

• master key is chose by default, if admin does not explicitly choose
• master key is flagged as "recommended"
• user key is flagged as "not supported"

Teminology and admin workflow are confusing:

• A "module" cannot be chosen. This step expects us to choose the default by enabling the one encryption "module" app we have.
• The text should say "No encryption module loaded, please enable an encryption module in the settings->apps menu."
• An "option" has to be chosen. This step is not announced, but is critical. The admin can only do this step, if he goes back to the settings -> encrpytion page -- (he came from there, and was sent to the settings -> apps page.)

[jnweiger]

Not a regression. Same issue seen in 10.8.0:

• User01 edits a shared.txt file with files_texteditor
• admin enables encryption, and enables the encryption app, but then leaves the waiting choice user/master alone.
• user01 tries to edit again. He sees sporadic gray messages "file has been changed" and cannot save.
• user01 closes the text editor and tries again:

Thus #39663 and everything similar is also not a regression.

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

[github-actions[bot]]

This issue has been automatically closed.