core icon indicating copy to clipboard operation
core copied to clipboard

Trashcan restore restores silently to home, if original subfolder is missing

Open jnweiger opened this issue 4 years ago • 7 comments

Seen in 10.9.0 beta1

  • have an external SFTP storage
  • create a subdirectory SFTP/xxx
  • create a file 'SFTP/xxx/Untitiled 1.odt' (using a desktop client)
  • delete the folder 'SFTP/xxx'
  • via web browser, visit the trashcan, click into xxx, and restore 'Untitled 1.odt' (without restoring xxx)
  • The file 'Untitled 1.odt' appears in the users home. Not in the external storage. BAD.
  • The file is also restored to home, if the the xxx folder was recreated manually inside SFTP.

Expected behavior:

  • autocreate the xxx folder.
  • (or at least) give a prominent message to the user, that his file is now elsewhere.

jnweiger avatar Dec 03 '21 20:12 jnweiger

This does not only happen with external storages, but also with internal ones. I'm not sure about the expected behavior, I think this is okay actually.

@pmaier1 could you please clarify? (1) Should the file be restored to root when restored without folder or (2) should the folder be recreated? Should we introduce a message if we decided to go with (1)?

Anyway, not a 10.9 regression.

JammingBen avatar Dec 09 '21 08:12 JammingBen

Puh, interesting corner case that actually originates from our flexible trash bin behavior. Others don't allow browsing the trash bin, so you don't encounter this.

I think the best user experience would be to restore the whole path, as expected by @jnweiger. But I think we can also live with the current behavior.

Not a blocker for 10.9.

pmaier1 avatar Dec 09 '21 10:12 pmaier1

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jun 08 '22 01:06 github-actions[bot]

This issue has been automatically closed.

github-actions[bot] avatar Jun 19 '22 01:06 github-actions[bot]

This looks like something to follow-up?

phil-davis avatar Jun 19 '22 05:06 phil-davis

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Dec 17 '22 01:12 github-actions[bot]

This issue has been automatically closed.

github-actions[bot] avatar Dec 27 '22 01:12 github-actions[bot]