core icon indicating copy to clipboard operation
core copied to clipboard

Published 20 hours ago • verified publisher icon owncloud

[full-ci] Expiration date limits for reshare of a received share

Open AlexAndBear opened this issue 2 years ago • 7 comments

Description

With this change, if a user re-shares an existent share with an expiration date, the expiration date of the target share will be taken for the new share, if the user doesn't provide an expiration date.

If the expiration date is provided and exceeds the date of the target share, an error will be thrown.

Related Issue

  • Fixes https://github.com/owncloud/core/issues/37013

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Database schema changes (next release will require increase of minor version instead of patch)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Technical debt
  • [ ] Tests only (no source changes)

Checklist:

  • [ ] Code changes
  • [ ] Unit tests added
  • [ ] Acceptance tests added
  • [ ] Documentation ticket raised:
  • [ ] Changelog item, see TEMPLATE

AlexAndBear avatar Nov 03 '21 14:11 AlexAndBear

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

update-docs[bot] avatar Nov 03 '21 14:11 update-docs[bot]

:boom: Acceptance tests pipeline apiShareReshareToRoot2-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33554/75/1

ownclouders avatar Nov 03 '21 15:11 ownclouders

:boom: Acceptance tests pipeline apiShareUpdateToShares-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33556/80/1

ownclouders avatar Nov 03 '21 15:11 ownclouders

:boom: Acceptance tests pipeline apiShareReshareToRoot2-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33567/75/1

ownclouders avatar Nov 04 '21 08:11 ownclouders

@JanAckermann any progress on that? Seems a reasonable change that could go into 10.11

mmattel avatar Jun 17 '22 13:06 mmattel

:boom: Acceptance tests pipeline apiShareReshareToRoot2-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/36072/76

ownclouders avatar Jun 18 '22 11:06 ownclouders

I rebased this in #40263 - if that works nicely, we can probably close this old PR.

phil-davis avatar Aug 03 '22 12:08 phil-davis