core icon indicating copy to clipboard operation
core copied to clipboard

[tests-only] [full-ci] transfers occ command test scenarios to cli test suites

Open sakshamgurung opened this issue 4 years ago • 9 comments

Description

Transfers occ command test scenarios to cli test suites

Related Issue

  • From https://github.com/owncloud/core/issues/39173?

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Database schema changes (next release will require increase of minor version instead of patch)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Technical debt
  • [x] Tests only (no source changes)

Checklist:

  • [ ] Code changes
  • [ ] Unit tests added
  • [ ] Acceptance tests added
  • [ ] Documentation ticket raised:
  • [ ] Changelog item, see TEMPLATE

sakshamgurung avatar Nov 01 '21 09:11 sakshamgurung

@phil-davis @kiranparajuli589 occ command scenarios in listed files needs to run with make test-acceptance-webui command which means I can't run them under make test-acceptance-cli command. Should I leave these tests?

  • webUIPersonalSettings/accessToChangeFullNameThroughConfig.feature
  • webUIPersonalSettings/personalGeneralSettings.feature

sakshamgurung avatar Nov 01 '21 09:11 sakshamgurung

@phil-davis @kiranparajuli589 occ command scenarios in listed files needs to run with make test-acceptance-webui command which means I can't run them under make test-acceptance-cli command. Should I leave these tests?

  • webUIPersonalSettings/accessToChangeFullNameThroughConfig.feature
  • webUIPersonalSettings/personalGeneralSettings.feature

@sakshamgurung, since the tests uses occ commands as when step, I think all these transferred tests should be moved inside cli suites, that should allow you to use make test-acceptance-cli too

kiranparajuli589 avatar Nov 02 '21 06:11 kiranparajuli589

New webUIWithCli folder is created to contain feature files that use both webui and cli contexts. Putting these files inside cli test suite don't allow the use of webui contexts and needs changes in drone and make files, so creating a separate folder inside webui test suite makes more ease.

sakshamgurung avatar Nov 02 '21 09:11 sakshamgurung

CI fails in a clone step :-(

individual-it avatar Nov 22 '21 06:11 individual-it

@sakshamgurung does this solve #39173 ?

individual-it avatar Nov 22 '21 06:11 individual-it

I converted to draft because we do not want to merge acceptance test refactorings to master while the 10.9.0 release process is in progress.

phil-davis avatar Nov 23 '21 06:11 phil-davis

Note: PR #39514 has the other pending test changes waiting for oC10 master.

I will look at this PR later in the week and sort out some refactoring related to having the new sysconfig endpoint in the testing app: https://github.com/owncloud/testing/pull/190

We can use that for system settings changes where the occ config:system:set command is being used just as a Given step in scenario setup.

This PR is no longer in a current project, because the code is "essentially done". I assigned myself so that I find it easily.

phil-davis avatar Nov 30 '21 08:11 phil-davis

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Dec 22 '21 04:12 sonarqubecloud[bot]

Note: there is no rush for this. I would like to sort out some things. I am away this coming week and will look at it the first week of 2022.

phil-davis avatar Dec 26 '21 15:12 phil-davis

I'll see what we can do on this.

kiranparajuli589 avatar Oct 11 '22 04:10 kiranparajuli589

CI failes with

+ php occ security:certificates:import /drone/server.crt
certificate not found

also there is more than only moving the tests happening here, please adjust original description

individual-it avatar Oct 13 '22 05:10 individual-it

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Oct 13 '22 06:10 sonarqubecloud[bot]