Remove scrollable scrollbar

[hurradieweltgehtunter]

Description

Current login screen has an always visible scrollbar to prevent a "jumping" of the login form. Certain constallations of notices and error messages can exceed the screens height which will result in a horiztonal jump of the login form (when scrollbar is added). Until now this was done via setting a height of 101% which made the scrollbar always visible - but also scrollable. This fix makes the scrollbar visible any time but not scrollable if not needed.

Related Issue

• Fixes https://github.com/owncloud/core/issues/39043

How Has This Been Tested?

Major browsers

Types of changes

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Database schema changes (next release will require increase of minor version instead of patch)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] Technical debt
• [ ] Tests only (no source changes)

Checklist:

• [x] Code changes
• [ ] Unit tests added
• [ ] Acceptance tests added
• [ ] Documentation ticket raised:
• [ ] Changelog item, see TEMPLATE

[update-docs[bot]]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[ownclouders]

:boom: Acceptance tests pipeline apiWebdavLocks-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31498/93/1

[ownclouders]

:boom: Acceptance tests pipeline apiShareManagementBasicToShares-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31498/71/1

[ownclouders]

:boom: Acceptance tests pipeline apiShareReshareToRoot1-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31498/78/1

[ownclouders]

:boom: Acceptance tests pipeline apiWebdavLocks3-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31498/95/1

[ownclouders]

:boom: Acceptance tests pipeline webUIFileActionsMenu-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31498/158/1

[ownclouders]

:boom: Acceptance tests pipeline webUIWebdavLocks-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31498/156/1

[ownclouders]

:boom: Acceptance tests pipeline apiProxySmoke-8-3-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31498/173/1

[ownclouders]

:boom: Acceptance tests pipeline apiOnSqlite-sqlite-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31498/179/1

[ownclouders]

:boom: Acceptance tests pipeline webUITags-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31498/152/1

[xoxys]

While this looks ok on the enterprise theme (due to the customized scrollbar design; at least on supported browsers) it looks still a bit "ugly" on the community theme which seems to use the browsers default scroll bar.

[hurradieweltgehtunter]

It always uses the browsers default scrollbar. Scrollbars are not stylable by css

[xoxys]

Looks different to me.

[hurradieweltgehtunter]

Scrollbar is disabled in left screenshot but not affected by css.

[xoxys]

I dont get it. There IS a scrollbar in the left screenshot. Both screenshots are running latest 10.8 docker image and the only difference is the used theme (enterprise/community)

[hurradieweltgehtunter]

Yes, there is a scrollbar in both screenshots. The scollbar in the left one is disabled (greyed out but visible) because the webpage's height does not exceed the viewport height. This is done by the browser. In the right the scrollbar is enabled because the webpage exceeds the viewports height. Also done by browser. Nothing CSS could manipulate. In both - and any - cases the browser default scrollbar is not stylable via css. The browser itself decides how it looks. It would be possible to create custom styled scrollbars with some CSS/JS magic but this would be too much effort. Using the browser default scrollbars is the preferred and recommended way.

[xoxys]

Ok let me ask it the other way around. Why do I have a different behavior with the same ownCloud version and the same browser at the same viewport height side-by-side on the same monitor?

[hurradieweltgehtunter]

Left one: you are using this PR which has a different method to show the scrollbar at any time Right one: your are using OC 10.8.0 which is using a webpage height of 101% as a hack to show the scrollbar at any time.

[xoxys]

What? Of course, I do not.... This PR is not merged, how should I use it? As I said multiple times now (please look at the URLs) both instances are using the exact same oC 10.8 docker image....

[hurradieweltgehtunter]

uhm ok ... then I'm not exactly sure whats happening. Both screens should be scrollable if it's 10.8.0. Maybe it only looks like the scrollbar on the left is disabled. Notice the slightly longer login form because of the ENTERPRISE EDITION tag above the form. This might be the reason why the left one is more scrollable?!

[sonarcloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[mmattel]

@hurradieweltgehtunter any update on this?

[phil-davis]

@hurradieweltgehtunter is this still something to finish?

[phil-davis]

@hurradieweltgehtunter is this still a thing that needs attention? If not, then close the PR. If so, then please rebase (or make a new PR to the current master) and we can review...

[hurradieweltgehtunter]

Honestly, I don't know. Given the age of that issue, my guess is: no